mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-04-22 10:04:44 +01:00
limit use of GetUserDataKey
This commit is contained in:
@@ -1617,9 +1617,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
throw new ArgumentNullException();
|
||||
}
|
||||
|
||||
var key = GetUserDataKey();
|
||||
|
||||
var data = UserDataManager.GetUserData(user.Id, key);
|
||||
var data = UserDataManager.GetUserData(user, this);
|
||||
|
||||
if (datePlayed.HasValue)
|
||||
{
|
||||
@@ -1654,9 +1652,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
throw new ArgumentNullException();
|
||||
}
|
||||
|
||||
var key = GetUserDataKey();
|
||||
|
||||
var data = UserDataManager.GetUserData(user.Id, key);
|
||||
var data = UserDataManager.GetUserData(user, this);
|
||||
|
||||
//I think it is okay to do this here.
|
||||
// if this is only called when a user is manually forcing something to un-played
|
||||
@@ -1987,14 +1983,14 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
public virtual bool IsPlayed(User user)
|
||||
{
|
||||
var userdata = UserDataManager.GetUserData(user.Id, GetUserDataKey());
|
||||
var userdata = UserDataManager.GetUserData(user, this);
|
||||
|
||||
return userdata != null && userdata.Played;
|
||||
}
|
||||
|
||||
public bool IsFavoriteOrLiked(User user)
|
||||
{
|
||||
var userdata = UserDataManager.GetUserData(user.Id, GetUserDataKey());
|
||||
var userdata = UserDataManager.GetUserData(user, this);
|
||||
|
||||
return userdata != null && (userdata.IsFavorite || (userdata.Likes ?? false));
|
||||
}
|
||||
@@ -2006,7 +2002,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
throw new ArgumentNullException("user");
|
||||
}
|
||||
|
||||
var userdata = UserDataManager.GetUserData(user.Id, GetUserDataKey());
|
||||
var userdata = UserDataManager.GetUserData(user, this);
|
||||
|
||||
return userdata == null || !userdata.Played;
|
||||
}
|
||||
|
||||
@@ -1635,7 +1635,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
var isUnplayed = true;
|
||||
|
||||
var itemUserData = UserDataManager.GetUserData(user.Id, child.GetUserDataKey());
|
||||
var itemUserData = UserDataManager.GetUserData(user, child);
|
||||
|
||||
// Incrememt totalPercentPlayed
|
||||
if (itemUserData != null)
|
||||
|
||||
@@ -348,7 +348,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
.Where(i => !i.IsFolder)
|
||||
.OfType<IHasAlbumArtist>();
|
||||
|
||||
var artists = _libraryManager.GetAlbumArtists(items).Where(i => _userDataManager.GetUserData(user.Id, i.GetUserDataKey()).IsFavorite);
|
||||
var artists = _libraryManager.GetAlbumArtists(items).Where(i => _userDataManager.GetUserData(user, i).IsFavorite);
|
||||
|
||||
return GetResult(artists, parent, query);
|
||||
}
|
||||
@@ -1218,7 +1218,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
if (query.IsLiked.HasValue)
|
||||
{
|
||||
userData = userData ?? userDataManager.GetUserData(user.Id, item.GetUserDataKey());
|
||||
userData = userData ?? userDataManager.GetUserData(user, item);
|
||||
|
||||
if (!userData.Likes.HasValue || userData.Likes != query.IsLiked.Value)
|
||||
{
|
||||
@@ -1228,7 +1228,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
if (query.IsFavoriteOrLiked.HasValue)
|
||||
{
|
||||
userData = userData ?? userDataManager.GetUserData(user.Id, item.GetUserDataKey());
|
||||
userData = userData ?? userDataManager.GetUserData(user, item);
|
||||
var isFavoriteOrLiked = userData.IsFavorite || (userData.Likes ?? false);
|
||||
|
||||
if (isFavoriteOrLiked != query.IsFavoriteOrLiked.Value)
|
||||
@@ -1239,7 +1239,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
if (query.IsFavorite.HasValue)
|
||||
{
|
||||
userData = userData ?? userDataManager.GetUserData(user.Id, item.GetUserDataKey());
|
||||
userData = userData ?? userDataManager.GetUserData(user, item);
|
||||
|
||||
if (userData.IsFavorite != query.IsFavorite.Value)
|
||||
{
|
||||
@@ -1249,7 +1249,7 @@ namespace MediaBrowser.Controller.Entities
|
||||
|
||||
if (query.IsResumable.HasValue)
|
||||
{
|
||||
userData = userData ?? userDataManager.GetUserData(user.Id, item.GetUserDataKey());
|
||||
userData = userData ?? userDataManager.GetUserData(user, item);
|
||||
var isResumable = userData.PlaybackPositionTicks > 0;
|
||||
|
||||
if (isResumable != query.IsResumable.Value)
|
||||
|
||||
@@ -45,6 +45,11 @@ namespace MediaBrowser.Controller.Library
|
||||
/// <returns>Task{UserItemData}.</returns>
|
||||
UserItemData GetUserData(Guid userId, string key);
|
||||
|
||||
UserItemData GetUserData(IHasUserData user, IHasUserData item);
|
||||
|
||||
UserItemData GetUserData(string userId, IHasUserData item);
|
||||
UserItemData GetUserData(Guid userId, IHasUserData item);
|
||||
|
||||
/// <summary>
|
||||
/// Gets the user data dto.
|
||||
/// </summary>
|
||||
|
||||
Reference in New Issue
Block a user