Comments and cleanup. ALso updated ffmpeg + ffprobe

MediaBrowser.Controller/Configuration/ServerApplicationPaths.cs

@@ -3,6 +3,9 @@ using MediaBrowser.Common.Configuration;
 
 namespace MediaBrowser.Controller.Configuration
 {
+    /// <summary>
+    /// Extends BaseApplicationPaths to add paths that are only applicable on the server
+    /// </summary>
     public class ServerApplicationPaths : BaseApplicationPaths
     {
         private string _rootFolderPath;

MediaBrowser.Controller/FFMpeg/ffmpeg.exe.REMOVED.git-id

@@ -1 +1 @@
-faf137524dd67edb423344830e1436dcdca83daf
+480bd76ce262d65df6b87802bd9bda18cf5b1c8f

MediaBrowser.Controller/FFMpeg/ffprobe.exe.REMOVED.git-id

@@ -1 +1 @@
-a304265e8410291c1f696e74a4f9b84970bb5753
+1f5e9773868e0f41260f64e20090803400b9a36d

MediaBrowser.Controller/Kernel.cs

@@ -49,6 +49,11 @@ namespace MediaBrowser.Controller
         /// </summary>
         [ImportMany(typeof(IBaseItemResolver))]
         private IEnumerable<IBaseItemResolver> EntityResolversEnumerable { get; set; }
+
+        /// <summary>
+        /// Once MEF has loaded the resolvers, sort them by priority and store them in this array
+        /// Given the sheer number of times they'll be iterated over it'll be faster to loop through an array
+        /// </summary>
         internal IBaseItemResolver[] EntityResolvers { get; private set; }
 
         /// <summary>

MediaBrowser.Controller/MediaBrowser.Controller.csproj

@@ -76,7 +76,6 @@
     <Compile Include="Resolvers\VideoResolver.cs" />
     <Compile Include="Resolvers\VirtualFolderResolver.cs" />
     <Compile Include="Xml\BaseItemXmlParser.cs" />
-    <Compile Include="Xml\FolderXmlParser.cs" />
     <Compile Include="Xml\XmlExtensions.cs" />
   </ItemGroup>
   <ItemGroup>

MediaBrowser.Controller/Providers/FolderProviderFromXml.cs

@@ -20,14 +20,17 @@ namespace MediaBrowser.Controller.Providers
             get { return MetadataProviderPriority.First; }
         }
 
-        public override Task FetchAsync(BaseEntity item, ItemResolveEventArgs args)
+        public async override Task FetchAsync(BaseEntity item, ItemResolveEventArgs args)
+        {
+            await Task.Run(() => { Fetch(item, args); }).ConfigureAwait(false);
+        }
+
+        private void Fetch(BaseEntity item, ItemResolveEventArgs args)
         {
             if (args.ContainsFile("folder.xml"))
             {
-                return Task.Run(() => { new FolderXmlParser().Fetch(item as Folder, Path.Combine(args.Path, "folder.xml")); });
+                new BaseItemXmlParser<Folder>().Fetch(item as Folder, Path.Combine(args.Path, "folder.xml"));
             }
-
-            return Task.FromResult<object>(null);
         }
     }
 }

MediaBrowser.Controller/Xml/FolderXmlParser.cs

@@ -1,12 +0,0 @@
-using MediaBrowser.Model.Entities;
-
-namespace MediaBrowser.Controller.Xml
-{
-    /// <summary>
-    /// Fetches metadata for a folder.
-    /// Since folder.xml contains no folder-specific values, no overrides are needed
-    /// </summary>
-    public class FolderXmlParser : BaseItemXmlParser<Folder>
-    {
-    }
-}