mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-06 22:32:57 +01:00
Some minor code cleanups
This commit is contained in:
parent
016590529f
commit
670a53258e
@@ -5,7 +5,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
{
|
||||
public abstract class BaseEmbeddedResourceHandler : BaseHandler
|
||||
{
|
||||
public BaseEmbeddedResourceHandler(string resourcePath)
|
||||
protected BaseEmbeddedResourceHandler(string resourcePath)
|
||||
: base()
|
||||
{
|
||||
ResourcePath = resourcePath;
|
||||
@@ -15,7 +15,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
|
||||
public override Task<string> GetContentType()
|
||||
{
|
||||
return Task.FromResult<string>(MimeTypes.GetMimeType(ResourcePath));
|
||||
return Task.FromResult(MimeTypes.GetMimeType(ResourcePath));
|
||||
}
|
||||
|
||||
protected override Task WriteResponseToOutputStream(Stream stream)
|
||||
|
||||
@@ -25,8 +25,8 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
}
|
||||
}
|
||||
|
||||
private bool _TotalContentLengthDiscovered = false;
|
||||
private long? _TotalContentLength = null;
|
||||
private bool _TotalContentLengthDiscovered;
|
||||
private long? _TotalContentLength;
|
||||
public long? TotalContentLength
|
||||
{
|
||||
get
|
||||
@@ -34,6 +34,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
if (!_TotalContentLengthDiscovered)
|
||||
{
|
||||
_TotalContentLength = GetTotalContentLength();
|
||||
_TotalContentLengthDiscovered = true;
|
||||
}
|
||||
|
||||
return _TotalContentLength;
|
||||
@@ -64,7 +65,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
}
|
||||
}
|
||||
|
||||
protected List<KeyValuePair<long, long?>> _RequestedRanges = null;
|
||||
private List<KeyValuePair<long, long?>> _RequestedRanges;
|
||||
protected IEnumerable<KeyValuePair<long, long?>> RequestedRanges
|
||||
{
|
||||
get
|
||||
@@ -367,7 +368,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
{
|
||||
DateTime? value = null;
|
||||
|
||||
return Task.FromResult<DateTime?>(value);
|
||||
return Task.FromResult(value);
|
||||
}
|
||||
|
||||
private bool IsResponseValid
|
||||
@@ -378,7 +379,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
}
|
||||
}
|
||||
|
||||
private Hashtable _FormValues = null;
|
||||
private Hashtable _FormValues;
|
||||
|
||||
/// <summary>
|
||||
/// Gets a value from form POST data
|
||||
|
||||
@@ -15,7 +15,7 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
|
||||
if (string.IsNullOrEmpty(format))
|
||||
{
|
||||
return Handlers.SerializationFormat.Json;
|
||||
return SerializationFormat.Json;
|
||||
}
|
||||
|
||||
return (SerializationFormat)Enum.Parse(typeof(SerializationFormat), format, true);
|
||||
@@ -26,16 +26,16 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
{
|
||||
switch (SerializationFormat)
|
||||
{
|
||||
case Handlers.SerializationFormat.Jsv:
|
||||
return Task.FromResult<string>("text/plain");
|
||||
case Handlers.SerializationFormat.Protobuf:
|
||||
return Task.FromResult<string>("application/x-protobuf");
|
||||
case SerializationFormat.Jsv:
|
||||
return Task.FromResult("text/plain");
|
||||
case SerializationFormat.Protobuf:
|
||||
return Task.FromResult("application/x-protobuf");
|
||||
default:
|
||||
return Task.FromResult<string>(MimeTypes.JsonMimeType);
|
||||
return Task.FromResult(MimeTypes.JsonMimeType);
|
||||
}
|
||||
}
|
||||
|
||||
private bool _ObjectToSerializeEnsured = false;
|
||||
private bool _ObjectToSerializeEnsured;
|
||||
private T _ObjectToSerialize;
|
||||
|
||||
private async Task EnsureObjectToSerialize()
|
||||
@@ -66,14 +66,14 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
|
||||
switch (SerializationFormat)
|
||||
{
|
||||
case Handlers.SerializationFormat.Jsv:
|
||||
JsvSerializer.SerializeToStream<T>(_ObjectToSerialize, stream);
|
||||
case SerializationFormat.Jsv:
|
||||
JsvSerializer.SerializeToStream(_ObjectToSerialize, stream);
|
||||
break;
|
||||
case Handlers.SerializationFormat.Protobuf:
|
||||
ProtobufSerializer.SerializeToStream<T>(_ObjectToSerialize, stream);
|
||||
case SerializationFormat.Protobuf:
|
||||
ProtobufSerializer.SerializeToStream(_ObjectToSerialize, stream);
|
||||
break;
|
||||
default:
|
||||
JsonSerializer.SerializeToStream<T>(_ObjectToSerialize, stream);
|
||||
JsonSerializer.SerializeToStream(_ObjectToSerialize, stream);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -33,8 +33,8 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
}
|
||||
}
|
||||
|
||||
private bool _SourceStreamEnsured = false;
|
||||
private Stream _SourceStream = null;
|
||||
private bool _SourceStreamEnsured;
|
||||
private Stream _SourceStream;
|
||||
private Stream SourceStream
|
||||
{
|
||||
get
|
||||
@@ -116,12 +116,12 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
value = File.GetLastWriteTimeUtc(Path);
|
||||
}
|
||||
|
||||
return Task.FromResult<DateTime?>(value);
|
||||
return Task.FromResult(value);
|
||||
}
|
||||
|
||||
public override Task<string> GetContentType()
|
||||
{
|
||||
return Task.FromResult<string>(MimeTypes.GetMimeType(Path));
|
||||
return Task.FromResult(MimeTypes.GetMimeType(Path));
|
||||
}
|
||||
|
||||
protected override Task PrepareResponse()
|
||||
@@ -141,21 +141,17 @@ namespace MediaBrowser.Common.Net.Handlers
|
||||
{
|
||||
return ServeCompleteRangeRequest(requestedRange, stream);
|
||||
}
|
||||
else if (TotalContentLength.HasValue)
|
||||
if (TotalContentLength.HasValue)
|
||||
{
|
||||
// This will have to buffer a portion of the content into memory
|
||||
return ServePartialRangeRequestWithKnownTotalContentLength(requestedRange, stream);
|
||||
}
|
||||
else
|
||||
{
|
||||
// This will have to buffer the entire content into memory
|
||||
return ServePartialRangeRequestWithUnknownTotalContentLength(requestedRange, stream);
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
return SourceStream.CopyToAsync(stream);
|
||||
|
||||
// This will have to buffer the entire content into memory
|
||||
return ServePartialRangeRequestWithUnknownTotalContentLength(requestedRange, stream);
|
||||
}
|
||||
|
||||
return SourceStream.CopyToAsync(stream);
|
||||
}
|
||||
|
||||
protected override void DisposeResponseStream()
|
||||
|
||||
Reference in New Issue
Block a user