fixes #2588 - OpenSubtitlesDownloader doesn't respect X-Ratelimit-Requests-Remaining

This commit is contained in:
Luke Pulverenti
2017-06-22 15:14:58 -04:00
parent e7706fa8a3
commit 6ff89eab78
4 changed files with 34 additions and 4 deletions

View File

@@ -10,6 +10,7 @@ using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using MediaBrowser.Common.Extensions;
namespace MediaBrowser.Providers.MediaInfo
{
@@ -139,7 +140,7 @@ namespace MediaBrowser.Providers.MediaInfo
request.IndexNumberEnd = episode.IndexNumberEnd;
request.SeriesName = episode.SeriesName;
}
try
{
var searchResults = await _subtitleManager.SearchSubtitles(request, cancellationToken).ConfigureAwait(false);
@@ -154,6 +155,9 @@ namespace MediaBrowser.Providers.MediaInfo
return true;
}
}
catch (RateLimitExceededException)
{
}
catch (Exception ex)
{
_logger.ErrorException("Error downloading subtitles", ex);

View File

@@ -133,7 +133,8 @@ namespace MediaBrowser.Providers.Subtitles
{
//var isText = MediaStream.IsTextFormat(response.Format);
using (var fs = _fileSystem.GetFileStream(savePath, FileOpenMode.Create, FileAccessMode.Write, FileShareMode.Read, true))
using (var fs = _fileSystem.GetFileStream(savePath, FileOpenMode.Create, FileAccessMode.Write,
FileShareMode.Read, true))
{
await stream.CopyToAsync(fs).ConfigureAwait(false);
}
@@ -154,6 +155,10 @@ namespace MediaBrowser.Providers.Subtitles
}
}
}
catch (RateLimitExceededException)
{
throw;
}
catch (Exception ex)
{
EventHelper.FireEventIfNotNull(SubtitleDownloadFailure, this, new SubtitleDownloadFailureEventArgs