Merge pull request #14309 from shanepowell/MediaInfoFixs
Some checks are pending
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run

Fix PeopleHelper.AddPerson Exceptions due to bad meta-data extracts.
This commit is contained in:
Shane Powell
2025-07-05 05:22:27 +12:00
committed by GitHub
parent 844d69ab64
commit 8dcb0bfecb
3 changed files with 26 additions and 16 deletions

View File

@@ -218,7 +218,7 @@ namespace MediaBrowser.Providers.MediaInfo
{
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = albumArtist.Trim(),
Name = albumArtist,
Type = PersonKind.AlbumArtist
});
}
@@ -250,7 +250,7 @@ namespace MediaBrowser.Providers.MediaInfo
{
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = performer.Trim(),
Name = performer,
Type = PersonKind.Artist
});
}
@@ -264,7 +264,7 @@ namespace MediaBrowser.Providers.MediaInfo
{
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = composer.Trim(),
Name = composer,
Type = PersonKind.Composer
});
}

View File

@@ -6,6 +6,7 @@ using System.Globalization;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Jellyfin.Data.Enums;
using Jellyfin.Extensions;
using MediaBrowser.Common.Configuration;
using MediaBrowser.Controller.Chapters;
@@ -516,12 +517,15 @@ namespace MediaBrowser.Providers.MediaInfo
foreach (var person in data.People)
{
PeopleHelper.AddPerson(people, new PersonInfo
if (!string.IsNullOrWhiteSpace(person.Name))
{
Name = person.Name.Trim(),
Type = person.Type,
Role = person.Role.Trim()
});
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = person.Name,
Type = person.Type,
Role = person.Role.Trim()
});
}
}
_libraryManager.UpdatePeople(video, people);

View File

@@ -200,20 +200,26 @@ public class AlbumMetadataService : MetadataService<MusicAlbum, AlbumInfo>
foreach (var albumArtist in item.AlbumArtists)
{
PeopleHelper.AddPerson(people, new PersonInfo
if (!string.IsNullOrWhiteSpace(albumArtist))
{
Name = albumArtist.Trim(),
Type = PersonKind.AlbumArtist
});
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = albumArtist,
Type = PersonKind.AlbumArtist
});
}
}
foreach (var artist in item.Artists)
{
PeopleHelper.AddPerson(people, new PersonInfo
if (!string.IsNullOrWhiteSpace(artist))
{
Name = artist.Trim(),
Type = PersonKind.Artist
});
PeopleHelper.AddPerson(people, new PersonInfo
{
Name = artist,
Type = PersonKind.Artist
});
}
}
LibraryManager.UpdatePeople(item, people);