Apply review suggestions

This commit is contained in:
Shadowghost
2022-04-02 02:55:42 +02:00
parent 128d54622a
commit a4e4b761d5
6 changed files with 53 additions and 28 deletions

View File

@@ -419,9 +419,9 @@ namespace MediaBrowser.MediaEncoding.Encoder
/// <exception cref="ArgumentException">Unrecognized InputType.</exception>
public string GetExternalSubtitleInputArgument(string inputFile)
{
var prefix = "file";
const string Prefix = "file";
return EncodingUtils.GetInputArgument(prefix, inputFile, MediaProtocol.File);
return EncodingUtils.GetInputArgument(Prefix, inputFile, MediaProtocol.File);
}
/// <summary>

View File

@@ -195,7 +195,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
MediaStream subtitleStream,
CancellationToken cancellationToken)
{
if (!subtitleStream.IsExternal || subtitleStream.Path.EndsWith(".mks"))
if (!subtitleStream.IsExternal || subtitleStream.Path.EndsWith(".mks", StringComparison.OrdinalIgnoreCase))
{
string outputFormat;
string outputCodec;
@@ -511,7 +511,7 @@ namespace MediaBrowser.MediaEncoding.Subtitles
await semaphore.WaitAsync(cancellationToken).ConfigureAwait(false);
var subtitleStreamIndex = mediaSource.MediaStreams.Where(i => i.Path == subtitleStream.Path).ToList().IndexOf(subtitleStream);
var subtitleStreamIndex = EncodingHelper.FindIndex(mediaSource.MediaStreams, subtitleStream);
try
{