Merge pull request #1 from jellyfin/master

Pull latest to my fork

MediaBrowser.Model/Activity/ActivityLogEntry.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using Microsoft.Extensions.Logging;
 

MediaBrowser.Model/Activity/IActivityManager.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Events;
 using MediaBrowser.Model.Querying;

MediaBrowser.Model/Activity/IActivityRepository.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Querying;
 

MediaBrowser.Model/ApiClient/ServerDiscoveryInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.ApiClient
 {
     public class ServerDiscoveryInfo
@@ -7,16 +9,19 @@ namespace MediaBrowser.Model.ApiClient
         /// </summary>
         /// <value>The address.</value>
         public string Address { get; set; }
+
         /// <summary>
         /// Gets or sets the server identifier.
         /// </summary>
         /// <value>The server identifier.</value>
         public string Id { get; set; }
+
         /// <summary>
         /// Gets or sets the name.
         /// </summary>
         /// <value>The name.</value>
         public string Name { get; set; }
+
         /// <summary>
         /// Gets or sets the endpoint address.
         /// </summary>

MediaBrowser.Model/Branding/BrandingOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Branding
 {
     public class BrandingOptions
@@ -7,6 +9,7 @@ namespace MediaBrowser.Model.Branding
         /// </summary>
         /// <value>The login disclaimer.</value>
         public string LoginDisclaimer { get; set; }
+
         /// <summary>
         /// Gets or sets the custom CSS.
         /// </summary>

MediaBrowser.Model/Channels/ChannelFeatures.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Channels

MediaBrowser.Model/Channels/ChannelFolderType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Channels
 {
     public enum ChannelFolderType

MediaBrowser.Model/Channels/ChannelInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Channels
 {
     public class ChannelInfo

MediaBrowser.Model/Channels/ChannelItemSortField.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Channels
 {
     public enum ChannelItemSortField

MediaBrowser.Model/Channels/ChannelMediaContentType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Channels
 {
     public enum ChannelMediaContentType

MediaBrowser.Model/Channels/ChannelMediaType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Channels
 {
     public enum ChannelMediaType

MediaBrowser.Model/Channels/ChannelQuery.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Querying;

MediaBrowser.Model/Collections/CollectionCreationResult.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Collections

MediaBrowser.Model/Configuration/AccessSchedule.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public class AccessSchedule
@@ -7,11 +9,13 @@ namespace MediaBrowser.Model.Configuration
         /// </summary>
         /// <value>The day of week.</value>
         public DynamicDayOfWeek DayOfWeek { get; set; }
+
         /// <summary>
         /// Gets or sets the start hour.
         /// </summary>
         /// <value>The start hour.</value>
         public double StartHour { get; set; }
+
         /// <summary>
         /// Gets or sets the end hour.
         /// </summary>

MediaBrowser.Model/Configuration/BaseApplicationConfiguration.cs

@@ -1,3 +1,6 @@
+using System;
+using System.Xml.Serialization;
+
 namespace MediaBrowser.Model.Configuration
 {
     /// <summary>
@@ -25,6 +28,24 @@ namespace MediaBrowser.Model.Configuration
         /// <value>The cache path.</value>
         public string CachePath { get; set; }
 
+        /// <summary>
+        /// Last known version that was ran using the configuration.
+        /// </summary>
+        /// <value>The version from previous run.</value>
+        [XmlIgnore]
+        public Version PreviousVersion { get; set; }
+
+        /// <summary>
+        /// Stringified PreviousVersion to be stored/loaded,
+        /// because System.Version itself isn't xml-serializable
+        /// </summary>
+        /// <value>String value of PreviousVersion</value>
+        public string PreviousVersionStr
+        {
+            get => PreviousVersion?.ToString();
+            set => PreviousVersion = Version.Parse(value);
+        }
+
         /// <summary>
         /// Initializes a new instance of the <see cref="BaseApplicationConfiguration" /> class.
         /// </summary>

MediaBrowser.Model/Configuration/DynamicDayOfWeek.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public enum DynamicDayOfWeek

MediaBrowser.Model/Configuration/EncodingOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public class EncodingOptions
@@ -8,12 +10,14 @@ namespace MediaBrowser.Model.Configuration
         public bool EnableThrottling { get; set; }
         public int ThrottleDelaySeconds { get; set; }
         public string HardwareAccelerationType { get; set; }
+
         /// <summary>
-        /// FFmpeg path as set by the user via the UI
+        /// FFmpeg path as set by the user via the UI.
         /// </summary>
         public string EncoderAppPath { get; set; }
+
         /// <summary>
-        /// The current FFmpeg path being used by the system and displayed on the transcode page
+        /// The current FFmpeg path being used by the system and displayed on the transcode page.
         /// </summary>
         public string EncoderAppPathDisplay { get; set; }
         public string VaapiDevice { get; set; }
@@ -29,7 +33,7 @@ namespace MediaBrowser.Model.Configuration
         public EncodingOptions()
         {
             DownMixAudioBoost = 2;
-            EnableThrottling = true;
+            EnableThrottling = false;
             ThrottleDelaySeconds = 180;
             EncodingThreadCount = -1;
             // This is a DRM device that is almost guaranteed to be there on every intel platform, plus it's the default one in ffmpeg if you don't specify anything

MediaBrowser.Model/Configuration/ImageOption.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using MediaBrowser.Model.Entities;
 
 namespace MediaBrowser.Model.Configuration
@@ -9,6 +11,7 @@ namespace MediaBrowser.Model.Configuration
         /// </summary>
         /// <value>The type.</value>
         public ImageType Type { get; set; }
+
         /// <summary>
         /// Gets or sets the limit.
         /// </summary>

MediaBrowser.Model/Configuration/ImageSavingConvention.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public enum ImageSavingConvention

MediaBrowser.Model/Configuration/LibraryOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using MediaBrowser.Model.Entities;
@@ -18,6 +20,7 @@ namespace MediaBrowser.Model.Configuration
         public bool ImportMissingEpisodes { get; set; }
         public bool EnableAutomaticSeriesGrouping { get; set; }
         public bool EnableEmbeddedTitles { get; set; }
+        public bool EnableEmbeddedEpisodeInfos { get; set; }
 
         public int AutomaticRefreshIntervalDays { get; set; }
 

MediaBrowser.Model/Configuration/MetadataConfiguration.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public class MetadataConfiguration

MediaBrowser.Model/Configuration/MetadataOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Configuration

MediaBrowser.Model/Configuration/MetadataPlugin.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public class MetadataPlugin

MediaBrowser.Model/Configuration/MetadataPluginSummary.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Entities;
 

MediaBrowser.Model/Configuration/MetadataPluginType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     /// <summary>

MediaBrowser.Model/Configuration/ServerConfiguration.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Dto;
 
@@ -162,6 +164,7 @@ namespace MediaBrowser.Model.Configuration
         public bool SkipDeserializationForBasicTypes { get; set; }
 
         public string ServerName { get; set; }
+
         public string BaseUrl
         {
             get => _baseUrl;
@@ -234,7 +237,7 @@ namespace MediaBrowser.Model.Configuration
             CodecsUsed = Array.Empty<string>();
             PathSubstitutions = Array.Empty<PathSubstitution>();
             IgnoreVirtualInterfaces = false;
-            EnableSimpleArtistDetection = true;
+            EnableSimpleArtistDetection = false;
 
             DisplaySpecialsWithinSeasons = true;
             EnableExternalContentInSuggestions = true;
@@ -244,7 +247,7 @@ namespace MediaBrowser.Model.Configuration
             PublicHttpsPort = DefaultHttpsPort;
             HttpServerPortNumber = DefaultHttpPort;
             HttpsPortNumber = DefaultHttpsPort;
-            EnableHttps = true;
+            EnableHttps = false;
             EnableDashboardResponseCaching = true;
             EnableCaseSensitiveItemIds = true;
 

MediaBrowser.Model/Configuration/SubtitlePlaybackMode.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public enum SubtitlePlaybackMode

MediaBrowser.Model/Configuration/UnratedItem.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public enum UnratedItem

MediaBrowser.Model/Configuration/UserConfiguration.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Configuration

MediaBrowser.Model/Configuration/XbmcMetadataOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Configuration
 {
     public class XbmcMetadataOptions

MediaBrowser.Model/Cryptography/ICryptoProvider.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Collections.Generic;
 
 namespace MediaBrowser.Model.Cryptography

MediaBrowser.Model/Devices/ContentUploadHistory.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Devices
 {
     public class ContentUploadHistory

MediaBrowser.Model/Devices/DeviceInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Session;
 
@@ -5,6 +7,11 @@ namespace MediaBrowser.Model.Devices
 {
     public class DeviceInfo
     {
+        public DeviceInfo()
+        {
+            Capabilities = new ClientCapabilities();
+        }
+
         public string Name { get; set; }
 
         /// <summary>
@@ -12,42 +19,43 @@ namespace MediaBrowser.Model.Devices
         /// </summary>
         /// <value>The identifier.</value>
         public string Id { get; set; }
+
         /// <summary>
         /// Gets or sets the last name of the user.
         /// </summary>
         /// <value>The last name of the user.</value>
         public string LastUserName { get; set; }
+
         /// <summary>
         /// Gets or sets the name of the application.
         /// </summary>
         /// <value>The name of the application.</value>
         public string AppName { get; set; }
+
         /// <summary>
         /// Gets or sets the application version.
         /// </summary>
         /// <value>The application version.</value>
         public string AppVersion { get; set; }
+
         /// <summary>
         /// Gets or sets the last user identifier.
         /// </summary>
         /// <value>The last user identifier.</value>
         public Guid LastUserId { get; set; }
+
         /// <summary>
         /// Gets or sets the date last modified.
         /// </summary>
         /// <value>The date last modified.</value>
         public DateTime DateLastActivity { get; set; }
+
         /// <summary>
         /// Gets or sets the capabilities.
         /// </summary>
         /// <value>The capabilities.</value>
         public ClientCapabilities Capabilities { get; set; }
 
-        public DeviceInfo()
-        {
-            Capabilities = new ClientCapabilities();
-        }
-
         public string IconUrl { get; set; }
     }
 }

MediaBrowser.Model/Devices/DeviceQuery.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Devices
@@ -9,6 +11,7 @@ namespace MediaBrowser.Model.Devices
         /// </summary>
         /// <value><c>null</c> if [supports synchronize] contains no value, <c>true</c> if [supports synchronize]; otherwise, <c>false</c>.</value>
         public bool? SupportsSync { get; set; }
+
         /// <summary>
         /// Gets or sets the user identifier.
         /// </summary>

MediaBrowser.Model/Devices/DevicesOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Devices

MediaBrowser.Model/Devices/LocalFileInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Devices
 {
     public class LocalFileInfo

MediaBrowser.Model/Diagnostics/IProcess.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.IO;
 using System.Threading.Tasks;

MediaBrowser.Model/Diagnostics/IProcessFactory.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Diagnostics
 {
     public interface IProcessFactory

MediaBrowser.Model/Dlna/AudioOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Dto;
 

MediaBrowser.Model/Dlna/CodecProfile.cs

@@ -1,3 +1,6 @@
+#pragma warning disable CS1591
+
+using System;
 using System.Xml.Serialization;
 using MediaBrowser.Model.Extensions;
 
@@ -20,8 +23,8 @@ namespace MediaBrowser.Model.Dlna
 
         public CodecProfile()
         {
-            Conditions = new ProfileCondition[] { };
-            ApplyConditions = new ProfileCondition[] { };
+            Conditions = Array.Empty<ProfileCondition>();
+            ApplyConditions = Array.Empty<ProfileCondition>();
         }
 
         public string[] GetCodecs()

MediaBrowser.Model/Dlna/CodecType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum CodecType

MediaBrowser.Model/Dlna/ConditionProcessor.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Globalization;
 using MediaBrowser.Model.Extensions;

MediaBrowser.Model/Dlna/ContainerProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Xml.Serialization;
 using MediaBrowser.Model.Extensions;

MediaBrowser.Model/Dlna/ContentFeatureBuilder.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Globalization;

MediaBrowser.Model/Dlna/DeviceIdentification.cs

@@ -1,3 +1,7 @@
+#pragma warning disable CS1591
+
+using System;
+
 namespace MediaBrowser.Model.Dlna
 {
     public class DeviceIdentification
@@ -7,46 +11,55 @@ namespace MediaBrowser.Model.Dlna
         /// </summary>
         /// <value>The name of the friendly.</value>
         public string FriendlyName { get; set; }
+
         /// <summary>
         /// Gets or sets the model number.
         /// </summary>
         /// <value>The model number.</value>
         public string ModelNumber { get; set; }
+
         /// <summary>
         /// Gets or sets the serial number.
         /// </summary>
         /// <value>The serial number.</value>
         public string SerialNumber { get; set; }
+
         /// <summary>
         /// Gets or sets the name of the model.
         /// </summary>
         /// <value>The name of the model.</value>
         public string ModelName { get; set; }
+
         /// <summary>
         /// Gets or sets the model description.
         /// </summary>
         /// <value>The model description.</value>
         public string ModelDescription { get; set; }
+
         /// <summary>
         /// Gets or sets the device description.
         /// </summary>
         /// <value>The device description.</value>
         public string DeviceDescription { get; set; }
+
         /// <summary>
         /// Gets or sets the model URL.
         /// </summary>
         /// <value>The model URL.</value>
         public string ModelUrl { get; set; }
+
         /// <summary>
         /// Gets or sets the manufacturer.
         /// </summary>
         /// <value>The manufacturer.</value>
         public string Manufacturer { get; set; }
+
         /// <summary>
         /// Gets or sets the manufacturer URL.
         /// </summary>
         /// <value>The manufacturer URL.</value>
         public string ManufacturerUrl { get; set; }
+
         /// <summary>
         /// Gets or sets the headers.
         /// </summary>
@@ -55,7 +68,7 @@ namespace MediaBrowser.Model.Dlna
 
         public DeviceIdentification()
         {
-            Headers = new HttpHeaderInfo[] { };
+            Headers = Array.Empty<HttpHeaderInfo>();
         }
     }
 }

MediaBrowser.Model/Dlna/DeviceProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Xml.Serialization;
 using MediaBrowser.Model.Extensions;

MediaBrowser.Model/Dlna/DeviceProfileInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public class DeviceProfileInfo

MediaBrowser.Model/Dlna/DeviceProfileType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum DeviceProfileType

MediaBrowser.Model/Dlna/DirectPlayProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/DlnaFlags.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/DlnaMaps.cs

@@ -1,6 +1,8 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
-    public class DlnaMaps
+    public static class DlnaMaps
     {
         private static readonly string DefaultStreaming =
              FlagsToString(DlnaFlags.StreamingTransferMode |

MediaBrowser.Model/Dlna/DlnaProfileType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum DlnaProfileType

MediaBrowser.Model/Dlna/EncodingContext.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum EncodingContext

MediaBrowser.Model/Dlna/HeaderMatchType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum HeaderMatchType

MediaBrowser.Model/Dlna/HttpHeaderInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/IDeviceDiscovery.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Events;
 

MediaBrowser.Model/Dlna/ITranscoderSupport.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public interface ITranscoderSupport

MediaBrowser.Model/Dlna/MediaFormatProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum MediaFormatProfile

MediaBrowser.Model/Dlna/MediaFormatProfileResolver.cs

@@ -1,7 +1,8 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using MediaBrowser.Model.Extensions;
 using MediaBrowser.Model.MediaInfo;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/PlaybackErrorCode.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum PlaybackErrorCode

MediaBrowser.Model/Dlna/ProfileCondition.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/ProfileConditionType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum ProfileConditionType

MediaBrowser.Model/Dlna/ProfileConditionValue.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum ProfileConditionValue

MediaBrowser.Model/Dlna/ResolutionConfiguration.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public class ResolutionConfiguration

MediaBrowser.Model/Dlna/ResolutionNormalizer.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Extensions;
 

MediaBrowser.Model/Dlna/ResolutionOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public class ResolutionOptions

MediaBrowser.Model/Dlna/ResponseProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/SearchCriteria.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Text.RegularExpressions;
 using MediaBrowser.Model.Extensions;

MediaBrowser.Model/Dlna/SearchType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum SearchType

MediaBrowser.Model/Dlna/SortCriteria.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using MediaBrowser.Model.Entities;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/StreamBuilder.cs

@@ -1,10 +1,11 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
 using MediaBrowser.Model.Dto;
 using MediaBrowser.Model.Entities;
-using MediaBrowser.Model.Extensions;
 using MediaBrowser.Model.MediaInfo;
 using MediaBrowser.Model.Session;
 using Microsoft.Extensions.Logging;
@@ -22,7 +23,7 @@ namespace MediaBrowser.Model.Dlna
             _logger = logger;
         }
 
-        public StreamBuilder(ILogger logger)
+        public StreamBuilder(ILogger<StreamBuilder> logger)
             : this(new FullTranscoderSupport(), logger)
         {
         }

MediaBrowser.Model/Dlna/StreamInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Globalization;
@@ -5,7 +7,6 @@ using System.Linq;
 using MediaBrowser.Model.Drawing;
 using MediaBrowser.Model.Dto;
 using MediaBrowser.Model.Entities;
-using MediaBrowser.Model.Extensions;
 using MediaBrowser.Model.MediaInfo;
 using MediaBrowser.Model.Session;
 

MediaBrowser.Model/Dlna/SubtitleDeliveryMethod.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum SubtitleDeliveryMethod
@@ -6,14 +8,17 @@ namespace MediaBrowser.Model.Dlna
         /// The encode
         /// </summary>
         Encode = 0,
+
         /// <summary>
         /// The embed
         /// </summary>
         Embed = 1,
+
         /// <summary>
         /// The external
         /// </summary>
         External = 2,
+
         /// <summary>
         /// The HLS
         /// </summary>

MediaBrowser.Model/Dlna/SubtitleProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 using MediaBrowser.Model.Extensions;
 

MediaBrowser.Model/Dlna/SubtitleStreamInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public class SubtitleStreamInfo

MediaBrowser.Model/Dlna/TranscodeSeekInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     public enum TranscodeSeekInfo

MediaBrowser.Model/Dlna/TranscodingProfile.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Dlna/UpnpDeviceInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Net;

MediaBrowser.Model/Dlna/VideoOptions.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dlna
 {
     /// <summary>

MediaBrowser.Model/Dlna/XmlAttribute.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System.Xml.Serialization;
 
 namespace MediaBrowser.Model.Dlna

MediaBrowser.Model/Drawing/DrawingUtils.cs

@@ -3,19 +3,19 @@ using System;
 namespace MediaBrowser.Model.Drawing
 {
     /// <summary>
-    /// Class DrawingUtils
+    /// Class DrawingUtils.
     /// </summary>
     public static class DrawingUtils
     {
         /// <summary>
-        /// Resizes a set of dimensions
+        /// Resizes a set of dimensions.
         /// </summary>
-        /// <param name="size">The original size object</param>
-        /// <param name="width">A new fixed width, if desired</param>
-        /// <param name="height">A new fixed height, if desired</param>
-        /// <param name="maxWidth">A max fixed width, if desired</param>
-        /// <param name="maxHeight">A max fixed height, if desired</param>
-        /// <returns>A new size object</returns>
+        /// <param name="size">The original size object.</param>
+        /// <param name="width">A new fixed width, if desired.</param>
+        /// <param name="height">A new fixed height, if desired.</param>
+        /// <param name="maxWidth">A max fixed width, if desired.</param>
+        /// <param name="maxHeight">A max fixed height, if desired.</param>
+        /// <returns>A new size object.</returns>
         public static ImageDimensions Resize(ImageDimensions size,
             int width,
             int height,

MediaBrowser.Model/Drawing/ImageDimensions.cs

@@ -1,36 +1,45 @@
+#pragma warning disable CS1591
+
+using System.Globalization;
+
 namespace MediaBrowser.Model.Drawing
 {
     /// <summary>
-    /// Struct ImageDimensions
+    /// Struct ImageDimensions.
     /// </summary>
-    public struct ImageDimensions
+    public readonly struct ImageDimensions
     {
-        /// <summary>
-        /// Gets or sets the height.
-        /// </summary>
-        /// <value>The height.</value>
-        public int Height { get; set; }
+        public ImageDimensions(int width, int height)
+        {
+            Width = width;
+            Height = height;
+        }
 
         /// <summary>
-        /// Gets or sets the width.
+        /// Gets the height.
+        /// </summary>
+        /// <value>The height.</value>
+        public int Height { get; }
+
+        /// <summary>
+        /// Gets the width.
         /// </summary>
         /// <value>The width.</value>
-        public int Width { get; set; }
+        public int Width { get; }
 
         public bool Equals(ImageDimensions size)
         {
             return Width.Equals(size.Width) && Height.Equals(size.Height);
         }
 
+        /// <inheritdoc />
         public override string ToString()
         {
-            return string.Format("{0}-{1}", Width, Height);
-        }
-
-        public ImageDimensions(int width, int height)
-        {
-            Width = width;
-            Height = height;
+            return string.Format(
+                CultureInfo.InvariantCulture,
+                "{0}-{1}",
+                Width,
+                Height);
         }
     }
 }

MediaBrowser.Model/Drawing/ImageFormat.cs

@@ -1,28 +1,32 @@
 namespace MediaBrowser.Model.Drawing
 {
     /// <summary>
-    /// Enum ImageOutputFormat
+    /// Enum ImageOutputFormat.
     /// </summary>
     public enum ImageFormat
     {
         /// <summary>
-        /// The BMP
+        /// The BMP.
         /// </summary>
         Bmp,
+
         /// <summary>
-        /// The GIF
+        /// The GIF.
         /// </summary>
         Gif,
+
         /// <summary>
-        /// The JPG
+        /// The JPG.
         /// </summary>
         Jpg,
+
         /// <summary>
-        /// The PNG
+        /// The PNG.
         /// </summary>
         Png,
+
         /// <summary>
-        /// The webp
+        /// The webp.
         /// </summary>
         Webp
     }

MediaBrowser.Model/Drawing/ImageOrientation.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Drawing
 {
     public enum ImageOrientation

MediaBrowser.Model/Dto/BaseItemDto.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using MediaBrowser.Model.Drawing;

MediaBrowser.Model/Dto/BaseItemPerson.cs

@@ -3,7 +3,7 @@ using System.Text.Json.Serialization;
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// This is used by the api to get information about a Person within a BaseItem
+    /// This is used by the api to get information about a Person within a BaseItem.
     /// </summary>
     public class BaseItemPerson
     {

MediaBrowser.Model/Dto/IHasServerId.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dto
 {
     public interface IHasServerId

MediaBrowser.Model/Dto/IItemDto.cs

@@ -1,7 +1,7 @@
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Interface IItemDto
+    /// Interface IItemDto.
     /// </summary>
     public interface IItemDto
     {

MediaBrowser.Model/Dto/ImageByNameInfo.cs

@@ -1,3 +1,4 @@
+#pragma warning disable CS1591
 
 namespace MediaBrowser.Model.Dto
 {
@@ -8,21 +9,25 @@ namespace MediaBrowser.Model.Dto
         /// </summary>
         /// <value>The name.</value>
         public string Name { get; set; }
+
         /// <summary>
         /// Gets or sets the theme.
         /// </summary>
         /// <value>The theme.</value>
         public string Theme { get; set; }
+
         /// <summary>
         /// Gets or sets the context.
         /// </summary>
         /// <value>The context.</value>
         public string Context { get; set; }
+
         /// <summary>
         /// Gets or sets the length of the file.
         /// </summary>
         /// <value>The length of the file.</value>
         public long FileLength { get; set; }
+
         /// <summary>
         /// Gets or sets the format.
         /// </summary>

MediaBrowser.Model/Dto/ImageInfo.cs

@@ -3,7 +3,7 @@ using MediaBrowser.Model.Entities;
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Class ImageInfo
+    /// Class ImageInfo.
     /// </summary>
     public class ImageInfo
     {

MediaBrowser.Model/Dto/ImageOptions.cs

@@ -4,7 +4,7 @@ using MediaBrowser.Model.Entities;
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Class ImageOptions
+    /// Class ImageOptions.
     /// </summary>
     public class ImageOptions
     {

MediaBrowser.Model/Dto/ItemCounts.cs

@@ -1,7 +1,7 @@
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Class LibrarySummary
+    /// Class LibrarySummary.
     /// </summary>
     public class ItemCounts
     {
@@ -10,48 +10,71 @@ namespace MediaBrowser.Model.Dto
         /// </summary>
         /// <value>The movie count.</value>
         public int MovieCount { get; set; }
+
         /// <summary>
         /// Gets or sets the series count.
         /// </summary>
         /// <value>The series count.</value>
         public int SeriesCount { get; set; }
+
         /// <summary>
         /// Gets or sets the episode count.
         /// </summary>
         /// <value>The episode count.</value>
         public int EpisodeCount { get; set; }
+
+        /// <summary>
+        /// Gets or sets the artist count.
+        /// </summary>
+        /// <value>The artist count.</value>
         public int ArtistCount { get; set; }
+
+        /// <summary>
+        /// Gets or sets the program count.
+        /// </summary>
+        /// <value>The program count.</value>
         public int ProgramCount { get; set; }
+
         /// <summary>
         /// Gets or sets the trailer count.
         /// </summary>
         /// <value>The trailer count.</value>
         public int TrailerCount { get; set; }
+
         /// <summary>
         /// Gets or sets the song count.
         /// </summary>
         /// <value>The song count.</value>
         public int SongCount { get; set; }
+
         /// <summary>
         /// Gets or sets the album count.
         /// </summary>
         /// <value>The album count.</value>
         public int AlbumCount { get; set; }
+
         /// <summary>
         /// Gets or sets the music video count.
         /// </summary>
         /// <value>The music video count.</value>
         public int MusicVideoCount { get; set; }
+
         /// <summary>
         /// Gets or sets the box set count.
         /// </summary>
         /// <value>The box set count.</value>
         public int BoxSetCount { get; set; }
+
         /// <summary>
         /// Gets or sets the book count.
         /// </summary>
         /// <value>The book count.</value>
         public int BookCount { get; set; }
+
+        /// <summary>
+        /// Gets or sets the item count.
+        /// </summary>
+        /// <value>The item count.</value>
         public int ItemCount { get; set; }
     }
 }

MediaBrowser.Model/Dto/ItemIndex.cs

@@ -1,7 +1,7 @@
 namespace MediaBrowser.Model.Dto
 {
     /// <summary>
-    /// Class ItemIndex
+    /// Class ItemIndex.
     /// </summary>
     public class ItemIndex
     {

MediaBrowser.Model/Dto/MediaSourceInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;
 using System.Text.Json.Serialization;

MediaBrowser.Model/Dto/MediaSourceType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dto
 {
     public enum MediaSourceType

MediaBrowser.Model/Dto/MetadataEditorInfo.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Globalization;

MediaBrowser.Model/Dto/NameIdPair.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 
 namespace MediaBrowser.Model.Dto
@@ -9,6 +11,7 @@ namespace MediaBrowser.Model.Dto
         /// </summary>
         /// <value>The name.</value>
         public string Name { get; set; }
+
         /// <summary>
         /// Gets or sets the identifier.
         /// </summary>

MediaBrowser.Model/Dto/NameValuePair.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dto
 {
     public class NameValuePair
@@ -18,6 +20,7 @@ namespace MediaBrowser.Model.Dto
         /// </summary>
         /// <value>The name.</value>
         public string Name { get; set; }
+
         /// <summary>
         /// Gets or sets the value.
         /// </summary>

MediaBrowser.Model/Dto/RatingType.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 namespace MediaBrowser.Model.Dto
 {
     public enum RatingType

MediaBrowser.Model/Dto/RecommendationDto.cs

@@ -1,3 +1,5 @@
+#pragma warning disable CS1591
+
 using System;
 using System.Collections.Generic;