Fix BaseItemKind conversion for PlaylistsFolder

Return the correct ClientTypeName to allow Enum Parse
Added dynamic unit tests to ensure all BaseItem concrete descend
This commit is contained in:
Luca Benini
2021-02-13 15:28:37 +01:00
parent 75ec8b0c8c
commit c4d142eda1
5 changed files with 124 additions and 1 deletions

View File

@@ -0,0 +1,62 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using MediaBrowser.Controller.Entities;
using Xunit;
namespace Jellyfin.Server.Tests
{
public class BaseItemKindTests
{
[Theory]
[ClassData(typeof(GetBaseItemDescendant))]
public void BaseKindEnumTest(Type baseItemDescendantType)
{
var defaultConstructor = baseItemDescendantType.GetConstructor(Type.EmptyTypes);
Assert.NotNull(defaultConstructor);
if (defaultConstructor != null)
{
var instance = (BaseItem)defaultConstructor.Invoke(null);
var exception = Record.Exception(() => instance.GetBaseItemKind());
Assert.Null(exception);
}
}
private static bool IsProjectAssemblyName(string? name)
{
if (name == null)
{
return false;
}
return name.Contains("Jellyfin", StringComparison.InvariantCulture)
|| name.Contains("Emby", StringComparison.InvariantCulture)
|| name.Contains("MediaBrowser", StringComparison.InvariantCulture)
|| name.Contains("RSSDP", StringComparison.InvariantCulture);
}
private class GetBaseItemDescendant : IEnumerable<object?[]>
{
public IEnumerator<object?[]> GetEnumerator()
{
var projectAssemblies = AppDomain.CurrentDomain.GetAssemblies()
.Where(x => IsProjectAssemblyName(x.FullName));
foreach (var projectAssembly in projectAssemblies)
{
var baseItemDescendantTypes = projectAssembly.GetTypes()
.Where(targetType => targetType.IsClass && !targetType.IsAbstract && targetType.IsSubclassOf(typeof(BaseItem)));
foreach (var descendantType in baseItemDescendantTypes)
{
yield return new object?[] { descendantType };
}
}
}
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
}
}
}

View File

@@ -0,0 +1,48 @@
<Project Sdk="Microsoft.NET.Sdk">
<!-- ProjectGuid is only included as a requirement for SonarQube analysis -->
<PropertyGroup>
<ProjectGuid>{0FD15BDA-FA63-4FFF-9E6B-781F20DA88D9}</ProjectGuid>
</PropertyGroup>
<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<IsPackable>false</IsPackable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<Nullable>enable</Nullable>
<RootNamespace>Jellyfin.Server.Tests</RootNamespace>
</PropertyGroup>
<ItemGroup>
<None Include="Test Data\**\*.*">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<PackageReference Include="AutoFixture" Version="4.15.0" />
<PackageReference Include="AutoFixture.AutoMoq" Version="4.15.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
<PackageReference Include="Moq" Version="4.16.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
<PackageReference Include="coverlet.collector" Version="3.0.2" />
</ItemGroup>
<!-- Code Analyzers -->
<ItemGroup Condition=" '$(Configuration)' == 'Debug' ">
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8" PrivateAssets="All" />
<PackageReference Include="SerilogAnalyzer" Version="0.15.0" PrivateAssets="All" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118" PrivateAssets="All" />
<PackageReference Include="SmartAnalyzers.MultithreadingAnalyzer" Version="1.1.31" PrivateAssets="All" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\Jellyfin.Server\Jellyfin.Server.csproj" />
</ItemGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<CodeAnalysisRuleSet>../jellyfin-tests.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>
</Project>