IceStormNG
26ac2ccd74
Backport pull request #15441 from jellyfin/release-10.11.z
...
Fix System.NullReferenceException when people's role is null (10.11.z)
Original-merge: 5a9a8363f4
Merged-by: Bond-009 <bond.009@outlook.com >
Backported-by: Bond_009 <bond.009@outlook.com >
2025-11-17 14:08:59 -05:00
gnattu
0a0aaefad5
Fix mka-style tagging key ( #14936 )
2025-10-02 17:33:31 -06:00
Corentin Malbet
71ebb1f456
Fixing the UFID field value giving a warning and not being correctly processed ( #14851 )
Stale PR Check / Check PRs with merge conflicts (push) Has been cancelled
Stale Issue Labeler / Check for stale issues (push) Has been cancelled
CodeQL / Analyze (csharp) (push) Has been cancelled
OpenAPI / OpenAPI - HEAD (push) Has been cancelled
OpenAPI / OpenAPI - BASE (push) Has been cancelled
Tests / run-tests (macos-latest) (push) Has been cancelled
Tests / run-tests (ubuntu-latest) (push) Has been cancelled
Tests / run-tests (windows-latest) (push) Has been cancelled
Project Automation / Project board (push) Has been cancelled
Merge Conflict Labeler / Labeling (push) Has been cancelled
OpenAPI / OpenAPI - Difference (push) Has been cancelled
OpenAPI / OpenAPI - Publish Unstable Spec (push) Has been cancelled
OpenAPI / OpenAPI - Publish Stable Spec (push) Has been cancelled
2025-09-26 14:24:59 -06:00
evan314159
e753adac2c
fix ProbeProvider.HasChanged: if file date changed ( #14674 )
2025-08-27 17:34:51 -06:00
evan314159
6f49782b7b
fix file modification date comparisons ( #14503 )
2025-07-27 20:08:06 -06:00
Nyanmisaka
25a362345d
Fix refreshing the library cannot delete old attachments ( #14461 )
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
2025-07-14 18:40:37 -06:00
renovate[bot]
8629831658
Update dependency z440.atl.core to v7 ( #14391 )
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
2025-07-07 18:10:48 -06:00
Shane Powell
8dcb0bfecb
Merge pull request #14309 from shanepowell/MediaInfoFixs
...
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
Fix PeopleHelper.AddPerson Exceptions due to bad meta-data extracts.
2025-07-04 19:22:27 +02:00
Evan
a4231bf428
Read ALBUMARTISTS in preference to ARTISTS when PreferNonstandardArtistsTag set
...
Jellyfin implemented ARTISTS multivalue tag but did not implement the equivalent ALBUMARTISTS multivalue tag. This change adds ALBUMARTISTS support. If present and PreferNonstandardArtistsTag is set, ALBUMARTISTS will be used in preference to ALBUMARTIST. As with ARTISTS, the intent is to offer support for multiple album artists without affecting software that does not read ALBUMARTIST as a multivalued tag.
Example album before/after:
ALBUM : Amici e Rivali
ARTIST : Lawrence Brownlee / Michael Spyres
album_artist : Lawrence Brownlee
ARTISTS : Lawrence Brownlee;Michael Spyres
ALBUMARTISTS : Lawrence Brownlee;Michael Spyres
Before ALBUMARTISTS support, Jellyfin reports:
Album Artist: Lawrence Brownlee [hyperlinked]
On each track Artist: Lawrence Brownlee, Michael Spyres
After ALBUMARTISTS support, Jellyfin reoprts:
Album Artist: Lawrence Brownlee [hyperlinked], Michael Spyres [hyperlinked]
On each track Artist: none shown (no other artists in source metadata)
This is ideal as both key artists are hyperlinkable from their albums.
References to other products implementing ALBUMARTISTS:
- Navidrome: https://www.navidrome.org/docs/usage/tagging-guidelines/#handling-multiple-artists-and-collaborations
- Kodi: https://kodi.wiki/view/Music_tagging#albumartists
- MusicBrainz Picard: https://picard-docs.musicbrainz.org/en/variables/variables_basic.html (_albumartists tag)
2025-07-02 07:55:24 +08:00
theguymadmax
b528c1100f
Fix missing music genre metadata ( #14332 )
2025-06-23 08:30:59 -06:00
gnattu
9d601f8e9b
Terminate at null char for audio tags ( #14100 )
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
2025-05-18 18:40:18 -06:00
theguymadmax
6c57ad4772
Fix Blu-ray metadata processing: preserve external streams and language metadata ( #14077 )
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
2025-05-09 08:35:54 -06:00
gnattu
140de04f94
Reject invalid replaygain tag value ( #14082 )
2025-05-09 08:35:41 -06:00
Tim Eisele
d976f13970
Recognize file changes and remove data on change ( #13839 )
CodeQL / Analyze (csharp) (push) Waiting to run
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
2025-05-04 21:21:44 -06:00
Tim Eisele
df5671263f
Merge pull request #13847 from Shadowghost/rework-chapter-management
...
Rework chapter management
2025-04-26 14:01:12 +02:00
Tim Eisele
61cb53999e
Safeguard against null value trimming in tag results ( #13908 )
2025-04-13 07:43:06 -06:00
Marc Brooks
a5f3d942f6
Merge branch 'master' into sort-nfo-data
2025-03-12 10:33:27 -05:00
gnattu
237e7bd44b
Backport pull request #13694 from jellyfin/release-10.10.z
...
OpenAPI / OpenAPI - HEAD (push) Waiting to run
OpenAPI / OpenAPI - BASE (push) Waiting to run
OpenAPI / OpenAPI - Difference (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Unstable Spec (push) Blocked by required conditions
OpenAPI / OpenAPI - Publish Stable Spec (push) Blocked by required conditions
Tests / run-tests (macos-latest) (push) Waiting to run
Tests / run-tests (ubuntu-latest) (push) Waiting to run
Tests / run-tests (windows-latest) (push) Waiting to run
Project Automation / Project board (push) Waiting to run
Merge Conflict Labeler / Labeling (push) Waiting to run
CodeQL / Analyze (csharp) (push) Has been cancelled
Clone fallback audio tags instead of use ATL.Track.set
Original-merge: 9eb2044eae
Merged-by: Bond-009 <bond.009@outlook.com >
Backported-by: Bond_009 <bond.009@outlook.com >
2025-03-12 08:40:33 -04:00
Dominik Krivohlavek
93dd5551df
Add support for reading and storing Recording MBIDs from file metadata ( #12173 )
...
* Add recording metadata provider
* Add recording MBID
* Save recording MBID during probing
* Set recording ID in probe result normalizer
* Add recording external media type
* Reimplement after changes in upstream
* Rename variable
* Rename variable
* Revert "Set recording ID in probe result normalizer"
This reverts commit 9dd18c8aba .
* Fix setting provider ID
* Simplify code
* Fix comment
* Add missing using
2025-02-28 23:00:52 -07:00
Marc Brooks
114591c1aa
Clean up usings and honor SortName
2025-02-25 01:51:38 -06:00
Cody Robibero
712908d53c
Revert nullability of MediaStream.IsHearingImpaired ( #13573 )
2025-02-17 19:20:18 -07:00
choyakawa
fb69b976bf
Fix the issue where the external audio track always defaults. ( #13132 )
2025-02-13 20:24:39 -07:00
gnattu
f4a2679177
Backport pull request #13490 from jellyfin/release-10.10.z
...
Correctly handle audio number tag fallbacks
Original-merge: 117d2082aa
Merged-by: joshuaboniface <joshua@boniface.me >
Backported-by: Bond_009 <bond.009@outlook.com >
2025-02-09 08:39:56 -05:00
Marc Brooks
4e64b261a8
Moved Trimmed to Jellyfin.Extensions.StringExtensions
2025-02-05 18:13:28 -06:00
Marc Brooks
e8cbcde02e
Merge branch 'master' into sort-nfo-data
2025-02-03 19:48:59 -06:00
gnattu
4c17498369
Backport pull request #13182 from jellyfin/release-10.10.z
...
Don't fall back to ffprobe results for multi-value audio tags
Original-merge: f97f38585b
Merged-by: Bond-009 <bond.009@outlook.com >
Backported-by: Bond_009 <bond.009@outlook.com >
2025-02-03 16:55:56 -05:00
Bond-009
bcdffa74a8
Remove useless checks and dead code ( #13405 )
...
* Remove useless checks and dead code
* Enable adaptive bitrate streaming again
* Disable adaptive bitrate streaming by default
2025-01-28 11:29:22 +01:00
Josh Soref
40da2ccac5
Fix spelling ( #13444 )
...
* spelling: anamorphic
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: associated
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: channelinfo
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: eagerly
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: enumerable
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: greater than/less than
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: greater
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: lineup
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: logs out
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: names
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: paging
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: playlist
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: sanitized
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
* spelling: saving
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
---------
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2025-01-28 11:27:34 +01:00
Bond_009
47f798827b
Remove useless checks and dead code
2025-01-22 17:31:52 +01:00
JPVenson
56a4aa180b
Fixed codesmell
2025-01-18 16:22:05 +00:00
JPVenson
2f306358c0
applied review comments
2025-01-18 16:17:26 +00:00
JPVenson
a0c568bc6c
Applied review comments
2024-12-15 14:46:40 +00:00
JPVenson
fe1aab034e
Merge branch 'jellyfin:master' into feature/EFUserData
2024-12-06 17:59:27 +01:00
Ethan Pippin
06923cbf2b
Implement TaskTriggerInfoType enum ( #12783 )
2024-12-01 17:08:37 -07:00
JPVenson
0dd6dacc4f
Merge remote-tracking branch 'origin/master' into feature/EFUserData
2024-11-19 20:53:38 +00:00
gnattu
7f296d06e6
Backport pull request #13003 from jellyfin/release-10.10.z
...
Only set first MusicBrainz ID for audio tags
Original-merge: e2434d38c5
Merged-by: crobibero <cody@robibe.ro >
Backported-by: Joshua M. Boniface <joshua@boniface.me >
2024-11-19 15:43:28 -05:00
JPVenson
d073e2c664
Fixed invalid columns on MediaStreams
2024-11-12 23:53:05 +00:00
JPVenson
b09a41ad1f
WIP porting new Repository structure
2024-10-09 10:36:08 +00:00
JPVenson
be48cdd9e9
Naming refactoring and WIP porting of new interface repositories
2024-10-09 09:53:39 +00:00
gnattu
7cc3f9506e
Disable ATL's internal ID3v2.2/3 splitting ( #12751 )
2024-09-30 07:15:52 -06:00
gnattu
992d56e565
Workaround ATL tag parsing ( #12705 )
2024-09-28 08:52:05 -06:00
gnattu
0ffddacf11
Move GetCustomTagDelimiters to Extension
2024-09-24 12:36:05 +08:00
gnattu
00ca4abbe1
Sanitize CustomTagDelimiters server side
...
The API requires an array type and does not support runtime generated default value. Use server side helper function to sanitize it into char.
2024-09-24 05:15:46 +08:00
Marc Brooks
6dc61a430b
Sort embedded collections in Nfo files
...
Because the Nfo files emit the collections as they are in-memory, the
files are not stable in format, genres, tags, albums, people, etc. are emitted in random orders. Add ordering of the collections when emitting the Nfo files so the file remains stable (unchanged) when underlying media information doesn't change.
In the process of this, it became clear that most of the providers and probes don't trim the strings like people's names, genre names, etc. so did a pass of Trim cleanup too.
Specific ordering: (alphabetical/numeric ascending after trimming blanks and defaulting to zero for missing numbers)
BaseItem: Directors, Writers, Trailers (by Url), Production Locations, Genres, Studios, Tags, Custom Provider Data (by key), Linked Children (by Path>LibraryItemId), Backdrop Images (by path), Actors (by SortOrder>Name)
AlbumNfo: Artists, Album Artists, Tracks (by ParentIndexNumber>IndexNumber>Name)
ArtistNfo: Albums (by Production Year>SortName>Name)
MovieNfo: Artists
Fix Debug build lint
Fix CI debug build lint issue.
Fix review issues
Fixed debug-build lint issues.
Emits the `disc` number to NFO for tracks with a non-zero ParentIndexNumber and only emit `position` if non-zero.
Removed the exception filtering I put in for testing.
Don't emit actors for MusicAlbums or MusicArtists
Swap from String.Trimmed() to ?.Trim()
Addressing PR feedback
Can't use ReadOnlySpan in an async method
Removed now-unused namespace
2024-09-18 20:33:18 -05:00
Shadowghost
2351eeba56
Rework PR 6203
2024-09-17 20:35:23 +02:00
gnattu
c6de7225b9
Add non-standard multi-value audio tag support ( #12385 )
2024-09-07 21:10:59 -06:00
gnattu
79c4469ac7
Remove redundant NaN check
...
Signed-off-by: gnattu <gnattuoc@me.com >
2024-07-29 06:23:16 +08:00
gnattu
5c5b326b1a
Remove test var
...
Co-authored-by: Cody Robibero <cody@robibe.ro >
2024-07-29 06:23:16 +08:00
gnattu
56a98a3bb0
Make internal value separator a constant
...
Signed-off-by: gnattu <gnattuoc@me.com >
2024-07-29 06:23:16 +08:00
gnattu
1d658a5a4d
Remove redundant check
...
Signed-off-by: gnattu <gnattuoc@me.com >
2024-07-29 06:23:13 +08:00