Commit Graph

52 Commits

Author SHA1 Message Date
Niels van Velzen
407cf5d0bf Add MediaStreamProtocol enum (#10153)
* Add MediaStreamProtocol enum

* Add default handling for enum during deserialization

---------

Co-authored-by: Cody Robibero <cody@robibe.ro>
2024-03-04 16:44:54 -07:00
Cody Robibero
0bc41c015f Store lyrics in the database as media streams (#9951) 2024-02-26 05:09:40 -07:00
Cody Robibero
e7b8d45bbb Use helper function to compare guid (#10825) 2024-01-17 08:51:39 -07:00
Bond_009
8ee1525894 Fix runtime errors 2023-11-14 22:01:10 +01:00
Bond_009
eb022c49cc Update to .NET 8 2023-11-14 21:12:16 +01:00
Bond_009
a9ef103c95 Add IDisposableAnalyzers to more projects 2023-11-05 02:01:14 +01:00
Bond_009
afc195286f Start adding IDisposableAnalyzers to projects 2023-09-23 15:15:58 +02:00
Lehonti Ramos
bc959270b7 Removed nesting levels through block-scoped using statement (#10025)
Co-authored-by: John Doe <john@doe>
Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-09-11 12:12:40 +02:00
Bond_009
18a311d32f == null -> is null 2023-08-22 21:14:54 +02:00
Bond_009
b5f0760db8 Use RegexGenerator where possible 2023-06-28 17:07:57 +02:00
Stepan Goremykin
910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin
26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
Bond-009
5b493e14ac Improve alternate ordering (#9336) 2023-02-20 08:07:51 -07:00
Bond-009
6fb2fac6e4 Always run code analyzers for tests projects (#9304) 2023-02-12 10:54:55 -07:00
Zoltan Csizmadia
e0519189b2 Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
Bond_009
65d605b17d Improve ffprobe json parsing and don't log error for Codec Type attachment 2023-02-01 14:58:04 +01:00
Bond_009
b7f2c8de5b Simplify AlphanumericComparator 2023-01-24 12:47:59 +01:00
renovate[bot]
e408da4651 chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Bond_009
6bf131b270 Use Diacritics.NET
Last time we had to revert this due to regressions, now those regression
tests seem to succeed with a newer version of Diacritics.NET
2022-12-27 16:53:58 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009
556cc8062d Investigate some TODO comments 2022-11-27 14:13:31 +01:00
MrTimscampi
7ad0c9ba24 Migrate MusicBrainz plugin to MetaBrainz.MusicBrainz
Co-authored-by: crobibero <cody@robibe.ro>
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2022-10-22 12:44:44 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Hannes Braun
4edeccc5e0 Remove redundant using directives 2022-09-28 16:26:03 +02:00
luz paz
9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero
40d3d8fb37 bump Jellyfin to 10.9 2022-07-13 21:00:56 -06:00
Cody Robibero
e4b095a766 Merge pull request #7894 from crobibero/search-hints
(cherry picked from commit 0f75f17736)
Signed-off-by: crobibero <cody@robibe.ro>
2022-06-14 19:30:59 -04:00
Bond-009
2b1a915ead Merge pull request #7604 from Jellifi007/fixes-diactritics
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:56 -04:00
dependabot[bot]
812841d01e Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 (#7726)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-09 15:24:09 +02:00
dependabot[bot]
dde984bd0e Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases)
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406)

---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-21 12:22:11 +00:00
Cody Robibero
e6df698df1 Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero
dbea7cac67 Use Enum.GetValues<T>() 2022-03-06 18:13:54 -07:00
Cody Robibero
c331e11c24 Clean up EnumFlags serialization 2022-03-06 18:13:54 -07:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Bond_009
2dcb2f8a9f Ban the usage of Task.Result
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2022-01-22 16:48:31 +01:00
Bond_009
cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Bond_009
ea9fc9f9cc Remove unreachable branches from JsonConverters
* If the type is a reference type we don't have to handle null ourselves
* reader.ValueSpan is only valid if reader.HasValueSequence is false
2021-12-19 02:20:46 +01:00
Claus Vium
8fc4a48070 Merge pull request #6501 from crobibero/schedules-direct 2021-10-09 23:21:09 +02:00
Cody Robibero
3bbd98cc3f Merge remote-tracking branch 'upstream/master' into schedules-direct 2021-10-08 07:49:40 -06:00
Bond_009
dc8feca6bb Remove duplicate Fisher–Yates shuffle impl 2021-10-08 15:20:11 +02:00
Bond_009
d4373a2ddb Use ConvertFrom with invariant culture instead of current culture 2021-10-01 10:54:06 +02:00
Bond_009
086d5925c9 Update Jellyfin.Extensions to .Net6 2021-09-24 20:15:46 +02:00
Bond_009
a6d1e542e6 Reduce allocations 2021-09-19 20:53:31 +02:00
Claus Vium
fffb57bb15 Merge pull request #6502 from crobibero/publish-jeff-extension
Add Jellyfin.Extensions to package publish
2021-09-14 13:44:46 +02:00
Fernando Fernández
3d0b1ccae6 Remove all unused usings 2021-09-06 21:15:30 +02:00
Cody Robibero
7a0a675bd5 Add Jellyfin.Extensions to package publish 2021-09-03 14:21:33 -06:00
Cody Robibero
058baf5abd Add IReadOnlyList extensions 2021-09-03 12:35:32 -06:00
Rich Lander
c07e83fdf8 Invert code and style analysis configuration (#6334)
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-07-30 09:49:28 +02:00
Maxr1998
11a5551218 Refactor ProbeResultNormalizer
Improve code structure and readability
2021-07-09 02:06:38 +02:00