From 0b0592a699277005b2540fd2462f35cb6d6d7db6 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Mon, 8 Sep 2025 16:15:23 +0200 Subject: [PATCH] fix: library sorting persistence by adding missing useEffect dependencies (#1047) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lostb1t <168401+lostb1t@users.noreply.github.com> Co-authored-by: lance chant <13349722+lancechant@users.noreply.github.com> --- app/(auth)/(tabs)/(libraries)/[libraryId].tsx | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/app/(auth)/(tabs)/(libraries)/[libraryId].tsx b/app/(auth)/(tabs)/(libraries)/[libraryId].tsx index 2f58d74c..d795fb91 100644 --- a/app/(auth)/(tabs)/(libraries)/[libraryId].tsx +++ b/app/(auth)/(tabs)/(libraries)/[libraryId].tsx @@ -77,7 +77,13 @@ const Page = () => { } else { _setSortBy([SortByOption.SortName]); } - }, []); + }, [ + libraryId, + sortOrderPreference, + sortByPreference, + _setSortOrder, + _setSortBy, + ]); const setSortBy = useCallback( (sortBy: SortByOption[]) => { @@ -87,7 +93,7 @@ const Page = () => { } _setSortBy(sortBy); }, - [libraryId, sortByPreference], + [libraryId, sortByPreference, setSortByPreference, _setSortBy], ); const setSortOrder = useCallback( @@ -101,7 +107,7 @@ const Page = () => { } _setSortOrder(sortOrder); }, - [libraryId, sortOrderPreference], + [libraryId, sortOrderPreference, setOderByPreference, _setSortOrder], ); const nrOfCols = useMemo(() => {