alteropen/streamyfin
1
0
Fork 0
mirror of https://github.com/streamyfin/streamyfin.git synced 2026-06-06 05:58:35 +01:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix(pr-validation): strip HTML comments via linear scan to satisfy CodeQL

Browse Source 
Replace the regex-based comment stripper (flagged by CodeQL
js/incomplete-multi-character-sanitization, alert #330) with a single linear
indexOf scan. Behaviour is identical on complete, unterminated and nested
comments, but there is no regex backtracking and no loop-until-stable, so the
CodeQL alert clears without reintroducing the CPU-DoS risk.
This commit is contained in:
Gauvino
2026-06-05 13:15:39 +02:00
parent 935cacff81
commit 116aff2f8e
1 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
scripts/check-pr-template.mjs
View File

@@ -29,15 +29,25 @@ try {
const association = (process.env.AUTHOR_ASSOCIATION || "").toUpperCase(); const association = (process.env.AUTHOR_ASSOCIATION || "").toUpperCase();
const isMaintainer = ["OWNER", "MEMBER", "COLLABORATOR"].includes(association); const isMaintainer = ["OWNER", "MEMBER", "COLLABORATOR"].includes(association);
// Strip HTML comments in a single linear pass: remove complete `<!-- … -->` // Strip HTML comments in a single linear pass (indexOf scan): no regex backtracking
// blocks, then drop any leftover unterminated `<!-- …` to end-of-string. This // and no loop-until-stable, so a crafted body can't drive it into super-linear time,
// leaves no `<!--` behind (satisfies CodeQL) without the quadratic re-scan loop // and it leaves no `<!--` behind. An unterminated `<!-- …` drops to end-of-string.
// a malicious deeply-nested body could abuse for CPU-DoS. const stripComments = (s) => {
const stripComments = (s) => let out = "";
s let i = 0;
.replace(/<!--[\s\S]*?-->/g, "") for (;;) {
.replace(/<!--[\s\S]*$/, "") const start = s.indexOf("<!--", i);
.trim(); if (start === -1) {
out += s.slice(i);
break;
}
out += s.slice(i, start);
const end = s.indexOf("-->", start + 4);
if (end === -1) break; // unterminated comment: drop the rest
i = end + 3;
}
return out.trim();
};
// Grab the text under a heading whose title contains `keyword`, up to the next heading // Grab the text under a heading whose title contains `keyword`, up to the next heading
// or the end of the body. // or the end of the body.