From 378288bf082ecaa7e46bd186bb91acf281dc47a4 Mon Sep 17 00:00:00 2001 From: Uruk Date: Wed, 14 Jan 2026 14:10:28 +0100 Subject: [PATCH] feat: add i18n support for skip button text - Add player.skip_* translation keys for all 5 segment types - Enable proper localization of skip button text - Addresses GitHub Copilot review comment --- components/video-player/controls/Controls.tsx | 8 +++++--- translations/en.json | 7 +++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/components/video-player/controls/Controls.tsx b/components/video-player/controls/Controls.tsx index 8ecf1844..aa2e1a84 100644 --- a/components/video-player/controls/Controls.tsx +++ b/components/video-player/controls/Controls.tsx @@ -5,6 +5,7 @@ import type { } from "@jellyfin/sdk/lib/generated-client"; import { useLocalSearchParams } from "expo-router"; import { type FC, useCallback, useEffect, useState } from "react"; +import { useTranslation } from "react-i18next"; import { StyleSheet, useWindowDimensions, View } from "react-native"; import Animated, { Easing, @@ -394,10 +395,11 @@ export const Controls: FC = ({ ? outroSkipper.currentSegment.endTime < maxSeconds : false; - // Get button text based on segment type + // Get button text based on segment type using i18n + const { t } = useTranslation(); const skipButtonText = activeSegment - ? `Skip ${activeSegment.type}` - : "Skip Intro"; + ? t(`player.skip_${activeSegment.type.toLowerCase()}`) + : t("player.skip_intro"); const goToItemCommon = useCallback( (item: BaseItemDto) => { diff --git a/translations/en.json b/translations/en.json index 81f8fdbb..a6d4bdab 100644 --- a/translations/en.json +++ b/translations/en.json @@ -24,6 +24,13 @@ "too_old_server_text": "Unsupported Jellyfin Server Discovered", "too_old_server_description": "Please update Jellyfin to the latest version" }, + "player": { + "skip_intro": "Skip Intro", + "skip_outro": "Skip Outro", + "skip_recap": "Skip Recap", + "skip_commercial": "Skip Commercial", + "skip_preview": "Skip Preview" + }, "server": { "enter_url_to_jellyfin_server": "Enter the URL to your Jellyfin server", "server_url_placeholder": "http(s)://your-server.com",