feat: added more subtitle customization options

Subtitles can now be customized with the following extra options:
- Colour
- background opacity/colour
- outline opacity/colour
- boldness

Signed-off-by: Lance Chant <13349722+lancechant@users.noreply.github.com>
This commit is contained in:
Lance Chant
2025-09-20 12:35:00 +02:00
parent 09b3cc7835
commit 621d164402
4 changed files with 470 additions and 2 deletions

View File

@@ -1,3 +1,4 @@
import { useEffect, useState } from "react";
import { Platform, TouchableOpacity, View, type ViewProps } from "react-native";
const _DropdownMenu = !Platform.isTV ? require("zeego/dropdown-menu") : null;
@@ -9,6 +10,7 @@ import { Switch } from "react-native-gesture-handler";
import Dropdown from "@/components/common/Dropdown";
import { Stepper } from "@/components/inputs/Stepper";
import { useSettings } from "@/utils/atoms/settings";
import { storage } from "@/utils/mmkv";
import { Text } from "../common/Text";
import { ListGroup } from "../list/ListGroup";
import { ListItem } from "../list/ListItem";
@@ -16,6 +18,32 @@ import { useMedia } from "./MediaContext";
interface Props extends ViewProps {}
const VLC_COLORS = {
Black: 0,
Gray: 8421504,
Silver: 12632256,
White: 16777215,
Maroon: 8388608,
Red: 16711680,
Fuchsia: 16711935,
Yellow: 16776960,
Olive: 8421376,
Green: 32768,
Teal: 32896,
Lime: 65280,
Purple: 8388736,
Navy: 128,
Blue: 255,
Aqua: 65535,
};
const OUTLINE_THICKNESS = {
None: 0,
Thin: 2,
Normal: 4,
Thick: 6,
};
export const SubtitleToggles: React.FC<Props> = ({ ...props }) => {
const isTv = Platform.isTV;
@@ -25,6 +53,52 @@ export const SubtitleToggles: React.FC<Props> = ({ ...props }) => {
const cultures = media.cultures;
const { t } = useTranslation();
// VLC subtitle styling states
const [textColor, setTextColor] = useState(
storage.getString("vlc.textColor") || "White",
);
const [backgroundColor, setBackgroundColor] = useState(
storage.getString("vlc.backgroundColor") || "Black",
);
const [outlineColor, setOutlineColor] = useState(
storage.getString("vlc.outlineColor") || "Black",
);
const [outlineThickness, setOutlineThickness] = useState(
storage.getString("vlc.outlineThickness") || "Normal",
);
const [backgroundOpacity, setBackgroundOpacity] = useState(
storage.getNumber("vlc.backgroundOpacity") || 128,
);
const [outlineOpacity, setOutlineOpacity] = useState(
storage.getNumber("vlc.outlineOpacity") || 255,
);
const [isBold, setIsBold] = useState(
storage.getBoolean("vlc.isBold") || false,
);
// VLC settings effects
useEffect(() => {
storage.set("vlc.textColor", textColor);
}, [textColor]);
useEffect(() => {
storage.set("vlc.backgroundColor", backgroundColor);
}, [backgroundColor]);
useEffect(() => {
storage.set("vlc.outlineColor", outlineColor);
}, [outlineColor]);
useEffect(() => {
storage.set("vlc.outlineThickness", outlineThickness);
}, [outlineThickness]);
useEffect(() => {
storage.set("vlc.backgroundOpacity", backgroundOpacity);
}, [backgroundOpacity]);
useEffect(() => {
storage.set("vlc.outlineOpacity", outlineOpacity);
}, [outlineOpacity]);
useEffect(() => {
storage.set("vlc.isBold", isBold);
}, [isBold]);
if (isTv) return null;
if (!settings) return null;
@@ -147,6 +221,139 @@ export const SubtitleToggles: React.FC<Props> = ({ ...props }) => {
onUpdate={(subtitleSize) => updateSettings({ subtitleSize })}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.text_color")}>
<Dropdown
data={Object.keys(VLC_COLORS)}
keyExtractor={(item) => item}
titleExtractor={(item) =>
t(`home.settings.subtitles.colors.${item}`)
}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>
{t(`home.settings.subtitles.colors.${textColor}`)}
</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.text_color")}
onSelected={setTextColor}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.background_color")}>
<Dropdown
data={Object.keys(VLC_COLORS)}
keyExtractor={(item) => item}
titleExtractor={(item) =>
t(`home.settings.subtitles.colors.${item}`)
}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>
{t(`home.settings.subtitles.colors.${backgroundColor}`)}
</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.background_color")}
onSelected={setBackgroundColor}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.outline_color")}>
<Dropdown
data={Object.keys(VLC_COLORS)}
keyExtractor={(item) => item}
titleExtractor={(item) =>
t(`home.settings.subtitles.colors.${item}`)
}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>
{t(`home.settings.subtitles.colors.${outlineColor}`)}
</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.outline_color")}
onSelected={setOutlineColor}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.outline_thickness")}>
<Dropdown
data={Object.keys(OUTLINE_THICKNESS)}
keyExtractor={(item) => item}
titleExtractor={(item) =>
t(`home.settings.subtitles.thickness.${item}`)
}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>
{t(`home.settings.subtitles.thickness.${outlineThickness}`)}
</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.outline_thickness")}
onSelected={setOutlineThickness}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.background_opacity")}>
<Dropdown
data={[0, 32, 64, 96, 128, 160, 192, 224, 255]}
keyExtractor={String}
titleExtractor={(item) => `${Math.round((item / 255) * 100)}%`}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>{`${Math.round((backgroundOpacity / 255) * 100)}%`}</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.background_opacity")}
onSelected={setBackgroundOpacity}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.outline_opacity")}>
<Dropdown
data={[0, 32, 64, 96, 128, 160, 192, 224, 255]}
keyExtractor={String}
titleExtractor={(item) => `${Math.round((item / 255) * 100)}%`}
title={
<TouchableOpacity className='flex flex-row items-center justify-between py-3 pl-3'>
<Text className='mr-1 text-[#8E8D91]'>{`${Math.round((outlineOpacity / 255) * 100)}%`}</Text>
<Ionicons
name='chevron-expand-sharp'
size={18}
color='#5A5960'
/>
</TouchableOpacity>
}
label={t("home.settings.subtitles.outline_opacity")}
onSelected={setOutlineOpacity}
/>
</ListItem>
<ListItem title={t("home.settings.subtitles.bold_text")}>
<Switch value={isBold} onValueChange={setIsBold} />
</ListItem>
</ListGroup>
</View>
);

View File

@@ -0,0 +1,156 @@
import { t } from "i18next";
import { useEffect, useState } from "react";
import { View } from "react-native";
import { ListGroup } from "@/components/list/ListGroup";
import { ListItem } from "@/components/list/ListItem";
import { storage } from "@/utils/mmkv";
const VLC_COLORS = {
Black: 0,
Gray: 8421504,
Silver: 12632256,
White: 16777215,
Maroon: 8388608,
Red: 16711680,
Fuchsia: 16711935,
Yellow: 16776960,
Olive: 8421376,
Green: 32768,
Teal: 32896,
Lime: 65280,
Purple: 8388736,
Navy: 128,
Blue: 255,
Aqua: 65535,
};
const OUTLINE_THICKNESS = {
None: 0,
Thin: 2,
Normal: 4,
Thick: 6,
};
export function VLCSubtitleSettings({
className = "",
}: {
className?: string;
}) {
const [textColor, setTextColor] = useState(
storage.getString("vlc.textColor") || "White",
);
const [backgroundColor, setBackgroundColor] = useState(
storage.getString("vlc.backgroundColor") || "Black",
);
const [outlineColor, setOutlineColor] = useState(
storage.getString("vlc.outlineColor") || "Black",
);
const [outlineThickness, setOutlineThickness] = useState(
storage.getString("vlc.outlineThickness") || "Normal",
);
const [backgroundOpacity, setBackgroundOpacity] = useState(
storage.getNumber("vlc.backgroundOpacity") || 128,
);
const [outlineOpacity, setOutlineOpacity] = useState(
storage.getNumber("vlc.outlineOpacity") || 255,
);
const [isBold, setIsBold] = useState(
storage.getBoolean("vlc.isBold") || false,
);
useEffect(() => {
storage.set("vlc.textColor", textColor);
}, [textColor]);
useEffect(() => {
storage.set("vlc.backgroundColor", backgroundColor);
}, [backgroundColor]);
useEffect(() => {
storage.set("vlc.outlineColor", outlineColor);
}, [outlineColor]);
useEffect(() => {
storage.set("vlc.outlineThickness", outlineThickness);
}, [outlineThickness]);
useEffect(() => {
storage.set("vlc.backgroundOpacity", backgroundOpacity);
}, [backgroundOpacity]);
useEffect(() => {
storage.set("vlc.outlineOpacity", outlineOpacity);
}, [outlineOpacity]);
useEffect(() => {
storage.set("vlc.isBold", isBold);
}, [isBold]);
return (
<View className={className}>
<ListGroup title={t("home.settings.vlc_subtitles.title")}>
<ListItem
title={t("home.settings.vlc_subtitles.text_color")}
value={textColor}
onPress={() => {
const colors = Object.keys(VLC_COLORS);
const currentIndex = colors.indexOf(textColor);
const nextIndex = (currentIndex + 1) % colors.length;
setTextColor(colors[nextIndex]);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.background_color")}
value={backgroundColor}
onPress={() => {
const colors = Object.keys(VLC_COLORS);
const currentIndex = colors.indexOf(backgroundColor);
const nextIndex = (currentIndex + 1) % colors.length;
setBackgroundColor(colors[nextIndex]);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.outline_color")}
value={outlineColor}
onPress={() => {
const colors = Object.keys(VLC_COLORS);
const currentIndex = colors.indexOf(outlineColor);
const nextIndex = (currentIndex + 1) % colors.length;
setOutlineColor(colors[nextIndex]);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.outline_thickness")}
value={outlineThickness}
onPress={() => {
const thicknesses = Object.keys(OUTLINE_THICKNESS);
const currentIndex = thicknesses.indexOf(outlineThickness);
const nextIndex = (currentIndex + 1) % thicknesses.length;
setOutlineThickness(thicknesses[nextIndex]);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.background_opacity")}
value={`${Math.round((backgroundOpacity / 255) * 100)}%`}
onPress={() => {
const newOpacity = (backgroundOpacity + 32) % 256;
setBackgroundOpacity(newOpacity);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.outline_opacity")}
value={`${Math.round((outlineOpacity / 255) * 100)}%`}
onPress={() => {
const newOpacity = (outlineOpacity + 32) % 256;
setOutlineOpacity(newOpacity);
}}
/>
<ListItem
title={t("home.settings.vlc_subtitles.bold_text")}
value={isBold ? "On" : "Off"}
onPress={() => setIsBold(!isBold)}
/>
</ListGroup>
</View>
);
}