alteropen/streamyfin
1
0
Fork 0
mirror of https://github.com/streamyfin/streamyfin.git synced 2026-05-28 09:38:25 +01:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix: unauthorized plugin access & null default values

Browse Source
This commit is contained in:
herrrta
2025-01-13 08:30:11 -05:00
parent c30f9860ee
commit 8a5f24002f
1 changed files with 6 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
utils/atoms/settings.ts
View File

@@ -5,12 +5,9 @@ import { storage } from "../mmkv";
import { Platform } from "react-native"; import { Platform } from "react-native";
import { import {
CultureDto, CultureDto,
PluginStatus,
SubtitlePlaybackMode, SubtitlePlaybackMode,
} from "@jellyfin/sdk/lib/generated-client"; } from "@jellyfin/sdk/lib/generated-client";
import { apiAtom } from "@/providers/JellyfinProvider"; import { apiAtom } from "@/providers/JellyfinProvider";
import { getPluginsApi } from "@jellyfin/sdk/lib/utils/api";
import { writeErrorLog } from "@/utils/log";
const STREAMYFIN_PLUGIN_ID = "1e9e5d386e6746158719e98a5c34f004"; const STREAMYFIN_PLUGIN_ID = "1e9e5d386e6746158719e98a5c34f004";
const STREAMYFIN_PLUGIN_SETTINGS = "STREAMYFIN_PLUGIN_SETTINGS"; const STREAMYFIN_PLUGIN_SETTINGS = "STREAMYFIN_PLUGIN_SETTINGS";
@@ -200,32 +197,12 @@ export const useSettings = () => {
const refreshStreamyfinPluginSettings = useCallback(async () => { const refreshStreamyfinPluginSettings = useCallback(async () => {
if (!api) return; if (!api) return;
const settings = await api
.getStreamyfinPluginConfig()
.then(({ data }) => data?.settings);
const plugins = await getPluginsApi(api) setPluginSettings(settings);
.getPlugins() return settings;
.then(({ data }) => data);
if (plugins && plugins.length > 0) {
const streamyfinPlugin = plugins.find(
(plugin) => plugin.Id === STREAMYFIN_PLUGIN_ID
);
if (!streamyfinPlugin || streamyfinPlugin.Status != PluginStatus.Active) {
writeErrorLog(
"Streamyfin plugin is currently not active.\n" +
`Current status is: ${streamyfinPlugin?.Status}`
);
setPluginSettings(undefined);
return;
}
const settings = await api
.getStreamyfinPluginConfig()
.then(({ data }) => data.settings);
setPluginSettings(settings);
return settings;
}
}, [api]); }, [api]);
const updateSettings = (update: Partial<Settings>) => { const updateSettings = (update: Partial<Settings>) => {
@@ -250,7 +227,7 @@ export const useSettings = () => {
// Make sure we override default settings with plugin settings when they are not locked. // Make sure we override default settings with plugin settings when they are not locked.
// Admin decided what users defaults should be and grants them the ability to change them too. // Admin decided what users defaults should be and grants them the ability to change them too.
if ( if (
!locked && locked === false &&
value && value &&
_settings?.[key as keyof Settings] !== value _settings?.[key as keyof Settings] !== value
) { ) {