Addressing PR comments

Signed-off-by: Lance Chant <13349722+lancechant@users.noreply.github.com>
This commit is contained in:
Lance Chant
2026-07-15 08:29:18 +02:00
parent 64b9224b7a
commit c4b6390a5e
4 changed files with 51 additions and 21 deletions

View File

@@ -6,6 +6,7 @@ import {
useCallback,
useContext,
useEffect,
useMemo,
useRef,
useState,
} from "react";
@@ -102,16 +103,25 @@ export function ServerUrlProvider({ children }: Props): React.ReactElement {
};
}, [ssid, permissionStatus, evaluateAndSwitchUrl]);
const value = useMemo(
() => ({
effectiveServerUrl,
isUsingLocalUrl,
currentSSID: ssid,
connectedToWifi,
refreshUrlState,
}),
[
effectiveServerUrl,
isUsingLocalUrl,
ssid,
connectedToWifi,
refreshUrlState,
],
);
return (
<ServerUrlContext.Provider
value={{
effectiveServerUrl,
isUsingLocalUrl,
currentSSID: ssid,
connectedToWifi,
refreshUrlState,
}}
>
<ServerUrlContext.Provider value={value}>
{children}
</ServerUrlContext.Provider>
);

View File

@@ -5,6 +5,7 @@ import {
useCallback,
useContext,
useEffect,
useMemo,
useState,
} from "react";
import { Platform } from "react-native";
@@ -129,16 +130,19 @@ export function WifiSsidProvider({ children }: Props): React.ReactElement {
return () => clearInterval(interval);
}, [permissionStatus, fetchSSID]);
const value = useMemo(
() => ({
ssid,
connectedToWifi,
permissionStatus,
requestPermission,
isLoading,
}),
[ssid, connectedToWifi, permissionStatus, requestPermission, isLoading],
);
return (
<WifiSsidContext.Provider
value={{
ssid,
connectedToWifi,
permissionStatus,
requestPermission,
isLoading,
}}
>
<WifiSsidContext.Provider value={value}>
{children}
</WifiSsidContext.Provider>
);