From d6ccd6f756833bdca6a08a66a42c261d43bc967e Mon Sep 17 00:00:00 2001
From: Uruk <contact@uruk.dev>
Date: Sun, 16 Nov 2025 00:37:36 +0100
Subject: [PATCH] fix(ios): remove root icon field to resolve build failure

Removing the root-level icon field allows the iOS-specific
liquid glass icon to be used without conflicts during the Xcode build.

This fixes the build error:
- None of the input catalogs contained a matching stickers icon set
  or app icon set named 'icon-ios-liquid-glass'
---
 PR_DESCRIPTION.md | 94 +++++++++++++++++++++++++++++++++++++++++++++++
 app.json          |  1 -
 2 files changed, 94 insertions(+), 1 deletion(-)
 create mode 100644 PR_DESCRIPTION.md

diff --git a/PR_DESCRIPTION.md b/PR_DESCRIPTION.md
new file mode 100644
index 00000000..dcae8145
--- /dev/null
+++ b/PR_DESCRIPTION.md
@@ -0,0 +1,94 @@
+# 📦 Pull Request
+
+## 🔖 Summary
+
+Upgrade runtime dependencies (react-i18next, react-native-worklets) and improve TypeScript type safety for screen orientation handling.
+
+## 🏷️ Ticket / Issue
+
+None
+
+## 🛠️ What's Changed
+
+- **Type**: chore
+- **Scope**: deps, refactor
+- **Summary**: Upgraded react-i18next and react-native-worklets to latest versions, improved type safety for screen orientation APIs
+
+## 📋 Details
+
+This PR upgrades key runtime dependencies and improves type safety across orientation-related code.
+
+### Changes Made
+
+**Runtime Dependencies Updated:**
+
+- `react-i18next`: 15.4.0 → 16.3.3 (latest internationalization features and improvements)
+- `react-native-worklets`: 0.5.1 → 0.6.1 (performance optimizations)
+- `typescript`: ^5.9.3 → ~5.9.3 (stricter version constraint for stability)
+
+**TypeScript Type Safety Improvements:**
+
+- Added explicit type annotations to orientation event handlers in `useOrientation` hook
+- Fixed `OrientationLock` type references to use proper enum types from `.tv.ts` module
+- Improved type consistency by using `Record<number, string>` for orientation enum mappings
+- Reorganized imports to follow consistent pattern (third-party → internal)
+
+### ⚠️ Breaking Changes
+
+None
+
+### 🔐 Security & Privacy Impact
+
+None
+
+### ⚡ Performance Impact
+
+- react-native-worklets 0.6.1 includes performance optimizations for worklet execution
+- No runtime behavior changes - orientation handling works exactly as before
+
+## ✅ Checklist
+
+- [x] I've read the [contribution guidelines](CONTRIBUTING.md)
+- [x] Code follows project style and passes lint/format (bun scripts)
+- [x] Type checks pass (tsc/biome/etc.)
+- [x] Docs updated (README/ADR/usage/API) - N/A for dependency updates
+- [x] No secrets/credentials included; env vars documented
+- [x] Release notes/CHANGELOG entry added (if applicable) - N/A for internal tooling
+- [x] Verified locally that changes behave as expected
+
+## 🔍 Testing Instructions
+
+1. Checkout branch: `git fetch origin && git checkout chore/update-dev-dependencies`
+2. Install dependencies: `bun install`
+3. Run type checks: `bun run typecheck`
+   - [x] Verify no TypeScript errors
+4. Run linter: `bun run lint`
+5. Test orientation features:
+   - [x] Screen rotation works correctly on mobile
+   - [x] Orientation lock/unlock functions work
+   - [x] TV platform continues to use landscape orientation
+6. Test i18n functionality:
+   - [x] Language switching works
+   - [x] Translations load correctly
+7. Verification steps:
+   - [x] All commands complete successfully
+   - [x] No runtime errors
+   - [x] Orientation behavior unchanged
+
+## ⚙️ Deployment Notes
+
+- No deployment impact - standard dependency updates
+- Team members will need to run `bun install` to update dependencies
+- No configuration changes required
+
+## 📝 Additional Notes
+
+**Why these updates?**
+
+- **react-i18next 16.3.3**: Latest stable version with improved TypeScript support and performance
+- **react-native-worklets 0.6.1**: Bug fixes and performance improvements for animation worklets
+- **TypeScript constraint change**: Using `~5.9.3` instead of `^5.9.3` to avoid unexpected minor version updates
+
+**Type safety improvements:**
+
+The TypeScript changes fix incorrect usage of `OrientationLock` as a type when it was actually a runtime value. Now we properly import the enum type from the `.tv.ts` module for type checking while keeping runtime behavior identical.
diff --git a/app.json b/app.json
index 8fe446c8..2b3d4205 100644
--- a/app.json
+++ b/app.json
@@ -4,7 +4,6 @@
     "slug": "streamyfin",
     "version": "0.47.1",
     "orientation": "default",
-    "icon": "./assets/images/icon.png",
     "scheme": "streamyfin",
     "userInterfaceStyle": "dark",
     "jsEngine": "hermes",