fix(chapters): address review comments - null starts, ticksToMs, a11y, memoize

This commit is contained in:
Uruk
2026-05-22 12:32:37 +02:00
parent 87b181b66f
commit f061e3b757
5 changed files with 39 additions and 10 deletions

View File

@@ -72,13 +72,18 @@ export function ChapterList({
<Text style={{ color: "#fff", fontSize: 17, fontWeight: "700" }}>
{t("chapters.title")}
</Text>
<Pressable onPress={onClose} hitSlop={10}>
<Pressable
onPress={onClose}
hitSlop={10}
accessibilityRole='button'
accessibilityLabel={t("chapters.close")}
>
<Ionicons name='close' size={24} color='#fff' />
</Pressable>
</View>
<FlatList
data={entries}
keyExtractor={(_, i) => String(i)}
keyExtractor={(item, index) => `${item.positionMs}-${index}`}
renderItem={({ item, index }) => {
const positionMs = item.positionMs;
const isActive = index === activeIndex;

View File

@@ -3,7 +3,8 @@ import type {
BaseItemDto,
ChapterInfo,
} from "@jellyfin/sdk/lib/generated-client";
import { type FC, useState } from "react";
import { type FC, useMemo, useState } from "react";
import { useTranslation } from "react-i18next";
import { Pressable, View } from "react-native";
import { Slider } from "react-native-awesome-slider";
import { type SharedValue } from "react-native-reanimated";
@@ -102,11 +103,16 @@ export const BottomControls: FC<BottomControlsProps> = ({
time,
}) => {
const { settings } = useSettings();
const { t } = useTranslation();
const insets = useSafeAreaInsets();
const [chapterListVisible, setChapterListVisible] = useState(false);
// Only expose chapter UI when there are at least two real markers.
const hasChapters = chapterMarkers(chapters, durationMs).length > 1;
const chapterMarkerList = useMemo(
() => chapterMarkers(chapters, durationMs),
[chapters, durationMs],
);
const hasChapters = chapterMarkerList.length > 1;
return (
<View
@@ -155,6 +161,9 @@ export const BottomControls: FC<BottomControlsProps> = ({
onPress={() => setChapterListVisible(true)}
hitSlop={10}
className='justify-center'
accessibilityRole='button'
accessibilityLabel={t("chapters.open")}
style={{ marginBottom: 6 }}
>
<Ionicons name='list' size={24} color='white' />
</Pressable>