fix(android): building and video playing with correct aspect ratio

app.json

@@ -34,7 +34,7 @@
     },
     "android": {
       "jsEngine": "hermes",
-      "versionCode": 89,
+      "versionCode": 90,
       "adaptiveIcon": {
         "foregroundImage": "./assets/images/icon-android-plain.png",
         "monochromeImage": "./assets/images/icon-android-themed.png",
@@ -63,7 +63,7 @@
           "android": {
             "buildArchs": ["arm64-v8a", "x86_64"],
             "compileSdkVersion": 36,
-            "targetSdkVersion": 34,
+            "targetSdkVersion": 35,
             "buildToolsVersion": "35.0.0",
             "kotlinVersion": "2.0.21",
             "minSdkVersion": 24,

components/AddToFavorites.tsx

@@ -16,6 +16,7 @@ export const AddToFavorites: FC<Props> = ({ item, ...props }) => {
       <RoundButton
         size='large'
         icon={isFavorite ? "heart" : "heart-outline"}
+        color={isFavorite ? "purple" : "white"}
         onPress={toggleFavorite}
       />
     </View>

components/RoundButton.tsx

@@ -104,7 +104,7 @@ export const RoundButton: React.FC<PropsWithChildren<Props>> = ({
           <Ionicons
             name={icon}
             size={size === "large" ? 22 : 18}
-            color={"white"}
+            color={color === "white" ? "white" : "#9334E9"}
           />
         ) : null}
         {children ? children : null}

modules/vlc-player/android/build.gradle

@@ -35,7 +35,7 @@ android {
 }
 
 dependencies {
-  implementation 'org.videolan.android:libvlc-all:3.6.0'
+  implementation 'org.videolan.android:libvlc-all:4.0.0-eap23'
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
 }
 

modules/vlc-player/android/src/main/java/expo/modules/vlcplayer/VlcPlayerModule.kt

@@ -63,16 +63,16 @@ class VlcPlayerModule : Module() {
         view.seekTo(time)
       }
 
-      AsyncFunction("setAudioTrack") { view: VlcPlayerView, trackIndex: Int ->
+      AsyncFunction("setAudioTrack") { view: VlcPlayerView, trackId: String ->
-        view.setAudioTrack(trackIndex)
+        view.setAudioTrack(trackId)
       }
 
       AsyncFunction("getAudioTracks") { view: VlcPlayerView ->
         view.getAudioTracks()
       }
 
-      AsyncFunction("setSubtitleTrack") { view: VlcPlayerView, trackIndex: Int ->
+      AsyncFunction("setSubtitleTrack") { view: VlcPlayerView, trackId: String ->
-        view.setSubtitleTrack(trackIndex)
+        view.setSubtitleTrack(trackId)
       }
 
       AsyncFunction("getSubtitleTracks") { view: VlcPlayerView ->

modules/vlc-player/android/src/main/java/expo/modules/vlcplayer/VlcPlayerView.kt

@@ -234,6 +234,7 @@ class VlcPlayerView(context: Context, appContext: AppContext) : ExpoView(context
         libVLC = LibVLC(context, initOptions)
         mediaPlayer = MediaPlayer(libVLC)
         mediaPlayer?.attachViews(videoLayout, null, false, false)
+        mediaPlayer?.setVideoScale(MediaPlayer.ScaleType.SURFACE_BEST_FIT)
         mediaPlayer?.setEventListener(this)
 
         log.debug("Loading network file: $uri")
@@ -294,38 +295,26 @@ class VlcPlayerView(context: Context, appContext: AppContext) : ExpoView(context
         }
     }
 
-    fun setAudioTrack(trackIndex: Int) {
+    fun setAudioTrack(trackId: String) {
-        mediaPlayer?.setAudioTrack(trackIndex)
+        // TODO: VLC 4.0 API - need to find correct method
+        log.debug("setAudioTrack called with $trackId - not yet implemented for VLC 4.0")
     }
 
     fun getAudioTracks(): List<Map<String, Any>>? {
-        log.debug("getAudioTracks ${mediaPlayer?.audioTracks}")
+        // TODO: VLC 4.0 API - need to find correct method
-        val trackDescriptions = mediaPlayer?.audioTracks ?: return null
+        log.debug("getAudioTracks - not yet implemented for VLC 4.0")
-
+        return emptyList()
-        return trackDescriptions.map { trackDescription ->
-            mapOf("name" to trackDescription.name, "index" to trackDescription.id)
-        }
     }
 
-    fun setSubtitleTrack(trackIndex: Int) {
+    fun setSubtitleTrack(trackId: String) {
-        mediaPlayer?.setSpuTrack(trackIndex)
+        // TODO: VLC 4.0 API - need to find correct method
+        log.debug("setSubtitleTrack called with $trackId - not yet implemented for VLC 4.0")
     }
 
-    // fun getSubtitleTracks(): List<Map<String, Any>>? {
-    //     return mediaPlayer?.getSpuTracks()?.map { trackDescription ->
-    //         mapOf("name" to trackDescription.name, "index" to trackDescription.id)
-    //     }
-    // }
-
     fun getSubtitleTracks(): List<Map<String, Any>>? {
-        val subtitleTracks = mediaPlayer?.spuTracks?.map { trackDescription ->
+        // TODO: VLC 4.0 API - need to find correct method
-            mapOf("name" to trackDescription.name, "index" to trackDescription.id)
+        log.debug("getSubtitleTracks - not yet implemented for VLC 4.0")
-        }
+        return emptyList()
-
-        // Debug statement to print the result
-        log.debug("Subtitle Tracks: $subtitleTracks")
-
-        return subtitleTracks
     }
 
     fun setSubtitleURL(subtitleURL: String, name: String) {