alteropen/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-06-02 05:48:47 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Compare old file byte-by-byte to new stream

Browse Source 
Don't overwrite if identical.
This commit is contained in:
Marc Brooks
2026-05-22 16:53:58 -05:00
parent 4af66c4e1a
commit 961c6d3d54
1 changed files with 73 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
MediaBrowser.XbmcMetadata/Savers/BaseNfoSaver.cs
View File

@@ -198,15 +198,23 @@ namespace MediaBrowser.XbmcMetadata.Savers
cancellationToken.ThrowIfCancellationRequested();
await SaveToFileAsync(memoryStream, path).ConfigureAwait(false);
await SaveToFileAsync(memoryStream, path, cancellationToken).ConfigureAwait(false);
}
}
private async Task SaveToFileAsync(Stream stream, string path)
private async Task SaveToFileAsync(Stream stream, string path, CancellationToken cancellationToken)
{
var directory = Path.GetDirectoryName(path) ?? throw new ArgumentException($"Provided path ({path}) is not valid.", nameof(path));
Directory.CreateDirectory(directory);
// Compare byte-for-byte before proceeding.
if (File.Exists(path) && await IsFileIdenticalAsync(stream, path, cancellationToken).ConfigureAwait(false))
{
return; // Don't save since .nfo is unchanged.
}
stream.Position = 0;
// On Windows, saving the file will fail if the file is hidden or readonly
FileSystem.SetAttributes(path, false, false);
@@ -222,7 +230,7 @@ namespace MediaBrowser.XbmcMetadata.Savers
var filestream = new FileStream(path, fileStreamOptions);
await using (filestream.ConfigureAwait(false))
{
await stream.CopyToAsync(filestream).ConfigureAwait(false);
await stream.CopyToAsync(filestream, cancellationToken).ConfigureAwait(false);
}
if (ConfigurationManager.Configuration.SaveMetadataHidden)
@@ -231,6 +239,68 @@ namespace MediaBrowser.XbmcMetadata.Savers
}
}
private static async Task<bool> IsFileIdenticalAsync(Stream stream, string path, CancellationToken cancellationToken)
{
ArgumentNullException.ThrowIfNull(stream);
ArgumentException.ThrowIfNullOrEmpty(path);
if (!stream.CanSeek)
{
return false;
}
const int BufferSize = 81920;
var originalPosition = stream.Position;
try
{
stream.Position = 0;
using var existingFileStream = new FileStream(
path,
FileMode.Open,
FileAccess.Read,
FileShare.Read,
bufferSize: BufferSize,
FileOptions.Asynchronous);
if (existingFileStream.Length != stream.Length)
{
return false;
}
var streamBuffer = new byte[BufferSize];
var existingBuffer = new byte[BufferSize];
while (true)
{
cancellationToken.ThrowIfCancellationRequested();
var streamBytesRead = await stream.ReadAsync(streamBuffer.AsMemory(), cancellationToken).ConfigureAwait(false);
var existingBytesRead = await existingFileStream.ReadAsync(existingBuffer.AsMemory(), cancellationToken).ConfigureAwait(false);
if (streamBytesRead != existingBytesRead)
{
return false;
}
if (streamBytesRead == 0)
{
return true;
}
if (!streamBuffer.AsSpan(0, streamBytesRead).SequenceEqual(existingBuffer.AsSpan(0, existingBytesRead)))
{
return false;
}
}
}
finally
{
stream.Position = originalPosition;
}
}
private void SetHidden(string path, bool hidden)
{
try