alteropen/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 07:46:32 +01:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix batch delete of items with same userdata keys

Browse Source
This commit is contained in:
Shadowghost
2026-03-07 21:23:35 +01:00
parent 5882006ee7
commit e6e7f2a692
1 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
Jellyfin.Server.Implementations/Item/ItemPersistenceService.cs
View File

@@ -77,16 +77,42 @@ public class ItemPersistenceService : IItemPersistenceService
var relatedItems = descendantIds.ToArray();
// When batch-deleting, multiple items may have UserData for the same (UserId, CustomDataKey).
// Moving all of them to PlaceholderId would violate the UNIQUE constraint.
// Deduplicate by loading keys client-side, keeping the best row per group.
var batchUserData = context.UserData.WhereOneOrMany(relatedItems, e => e.ItemId);
var allRows = batchUserData
.Select(ud => new { ud.ItemId, ud.UserId, ud.CustomDataKey, ud.LastPlayedDate, ud.PlayCount })
.ToList();
var duplicateRows = allRows
.GroupBy(ud => new { ud.UserId, ud.CustomDataKey })
.Where(g => g.Count() > 1)
.SelectMany(g => g
.OrderByDescending(ud => ud.LastPlayedDate)
.ThenByDescending(ud => ud.PlayCount)
.Skip(1))
.ToList();
foreach (var dup in duplicateRows)
{
context.UserData
.Where(ud => ud.ItemId == dup.ItemId && ud.UserId == dup.UserId && ud.CustomDataKey == dup.CustomDataKey)
.ExecuteDelete();
}
// Delete existing placeholder rows that would conflict with the incoming ones
context.UserData
.Join(
context.UserData.WhereOneOrMany(relatedItems, e => e.ItemId),
batchUserData,
placeholder => new { placeholder.UserId, placeholder.CustomDataKey },
userData => new { userData.UserId, userData.CustomDataKey },
(placeholder, userData) => placeholder)
.Where(e => e.ItemId == BaseItemRepository.PlaceholderId)
.ExecuteDelete();
context.UserData.WhereOneOrMany(relatedItems, e => e.ItemId)
batchUserData
.ExecuteUpdate(e => e
.SetProperty(f => f.RetentionDate, date)
.SetProperty(f => f.ItemId, BaseItemRepository.PlaceholderId));