alteropen/streamyfin
1
0
Fork 0
mirror of https://github.com/streamyfin/streamyfin.git synced 2026-01-15 15:48:05 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix(player): load external subtitles for offline playback
Some checks failed
🏗️ Build Apps / 🤖 Build Android APK (Phone) (push) Has been cancelled
Details
🏗️ Build Apps / 🤖 Build Android APK (TV) (push) Has been cancelled
Details
🏗️ Build Apps / 🍎 Build iOS IPA (Phone) (push) Has been cancelled
Details
🔒 Lockfile Consistency Check / 🔍 Check bun.lock and package.json consistency (push) Has been cancelled
Details
🛡️ CodeQL Analysis / 🔎 Analyze with CodeQL (actions) (push) Has been cancelled
Details
🛡️ CodeQL Analysis / 🔎 Analyze with CodeQL (javascript-typescript) (push) Has been cancelled
Details
🏷️🔀Merge Conflict Labeler / 🏷️ Labeling Merge Conflicts (push) Has been cancelled
Details
🌐 Translation Sync / sync-translations (push) Has been cancelled
Details
🚦 Security & Quality Gate / 📝 Validate PR Title (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🔍 Vulnerable Dependencies (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🚑 Expo Doctor Check (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🔍 Lint & Test (check) (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🔍 Lint & Test (format) (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🔍 Lint & Test (lint) (push) Has been cancelled
Details
🚦 Security & Quality Gate / 🔍 Lint & Test (typecheck) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Fredrik Burmester
2026-01-08 21:51:24 +01:00
parent d1387ec725
commit 097001b092
1 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/(auth)/player/direct-player.tsx
View File

@@ -568,8 +568,9 @@ export default function page() {
const mediaSource = stream.mediaSource;
const isTranscoding = Boolean(mediaSource?.TranscodingUrl);
// For offline playback, subtitles are embedded in the downloaded file
// For online playback, get external subtitle URLs from server
// Get external subtitle URLs
// - Online: prepend API base path to server URLs
// - Offline: use local file paths (stored in DeliveryUrl during download)
let externalSubs: string[] | undefined;
if (!offline && api?.basePath) {
externalSubs = mediaSource?.MediaStreams?.filter(
@@ -578,6 +579,13 @@ export default function page() {
s.DeliveryMethod === "External" &&
s.DeliveryUrl,
).map((s) => `${api.basePath}${s.DeliveryUrl}`);
} else if (offline) {
externalSubs = mediaSource?.MediaStreams?.filter(
(s) =>
s.Type === "Subtitle" &&
s.DeliveryMethod === "External" &&
s.DeliveryUrl,
).map((s) => s.DeliveryUrl!);
}
// Calculate track IDs for initial selection
@@ -641,7 +649,9 @@ export default function page() {
const mediaSource = stream.mediaSource;
const isTranscoding = Boolean(mediaSource?.TranscodingUrl);
// For VLC, external subtitles need name and DeliveryUrl
// Get external subtitle URLs for VLC (need name and DeliveryUrl)
// - Online: prepend API base path to server URLs
// - Offline: use local file paths (stored in DeliveryUrl during download)
let externalSubs: { name: string; DeliveryUrl: string }[] | undefined;
if (!offline && api?.basePath) {
externalSubs = mediaSource?.MediaStreams?.filter(
@@ -653,6 +663,16 @@ export default function page() {
name: s.DisplayTitle || s.Title || `Subtitle ${s.Index}`,
DeliveryUrl: `${api.basePath}${s.DeliveryUrl}`,
}));
} else if (offline) {
externalSubs = mediaSource?.MediaStreams?.filter(
(s) =>
s.Type === "Subtitle" &&
s.DeliveryMethod === "External" &&
s.DeliveryUrl,
).map((s) => ({
name: s.DisplayTitle || s.Title || `Subtitle ${s.Index}`,
DeliveryUrl: s.DeliveryUrl!,
}));
}
// Build VLC init options (required for VLC to work properly)