chore: git hygiene — enforce LF, drop dead .gitattributes/.gitignore rules

- .gitattributes: 'text=auto eol=lf' so files are stored and checked out as LF
  on every OS (no more CRLF churn on Windows, regardless of core.autocrlf);
  mark common binaries; keep .bat/.cmd as CRLF.
- Remove the stale Git LFS rule for modules/vlc-player (that module no longer
  exists and no LFS objects are tracked).
- .gitignore: stop ignoring bun.lock (it's committed and checked by the lockfile
  workflow), and replace the dead/duplicate per-module build paths (player,
  hls-downloader, sf-player, music-controls, duplicate mpv-player) with a single
  modules/*/android/build/ glob.
- Renormalise the one CRLF-stored file (crowdin.yml) to LF (EOL only).

.gitattributes

@@ -1 +1,28 @@
-.modules/vlc-player/Frameworks/*.xcframework filter=lfs diff=lfs merge=lfs -text
+# Normalise line endings to LF for everyone. Files are stored as LF in git and
+# checked out as LF on every OS, so Windows clones stop producing CRLF churn
+# (no more "LF will be replaced by CRLF" warnings) regardless of core.autocrlf.
+* text=auto eol=lf
+
+# Windows-only scripts must stay CRLF
+*.bat text eol=crlf
+*.cmd text eol=crlf
+
+# Binary assets — never touched / never normalised
+*.png binary
+*.jpg binary
+*.jpeg binary
+*.gif binary
+*.webp binary
+*.ico binary
+*.icns binary
+*.ttf binary
+*.otf binary
+*.woff binary
+*.woff2 binary
+*.mp3 binary
+*.mp4 binary
+*.mov binary
+*.pdf binary
+*.keystore binary
+*.jks binary
+*.p12 binary

.github/workflows/detect-duplicate.yml

@@ -1,38 +0,0 @@
-name: 🔁 Detect Duplicate Issues
-
-on:
-  issues:
-    types: [opened]
-
-permissions:
-  contents: read
-
-concurrency:
-  group: detect-duplicate-${{ github.event.issue.number }}
-  cancel-in-progress: true
-
-jobs:
-  detect:
-    name: 🔍 Find similar issues
-    if: github.actor != 'github-actions[bot]'
-    runs-on: ubuntu-24.04
-    permissions:
-      issues: write
-      contents: read
-    steps:
-      - name: 📥 Checkout repository
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-
-      - name: 🍞 Setup Bun
-        uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
-        with:
-          bun-version: latest
-
-      - name: 🔍 Detect duplicate issues
-        run: bun scripts/detect-duplicate-issue.mjs
-        env:
-          GH_TOKEN: ${{ github.token }}
-          GITHUB_REPOSITORY: ${{ github.repository }}
-          ISSUE_NUMBER: ${{ github.event.issue.number }}
-          ISSUE_TITLE: ${{ github.event.issue.title }}
-          ISSUE_BODY: ${{ github.event.issue.body }}

.gitignore

@@ -1,6 +1,5 @@
 # Dependencies and Package Managers
 node_modules/
-bun.lock
 bun.lockb
 package-lock.json
 
@@ -21,10 +20,8 @@ web-build/
 # Gradle caches (top-level + per-module native projects)
 **/.gradle/
 
-# Module-specific Builds
+# Native module build outputs (any module)
-modules/mpv-player/android/build
+modules/*/android/build/
-modules/player/android
-modules/hls-downloader/android/build
 
 # Generated Applications
 Streamyfin.app
@@ -69,10 +66,6 @@ certs/
 
 # Version and Backup Files
 /version-backup-*
-/modules/sf-player/android/build
-/modules/music-controls/android/build
-modules/background-downloader/android/build/*
-/modules/mpv-player/android/build
 
 # ios:unsigned-build Artifacts
 build/

components/video-player/controls/Controls.tv.tsx

@@ -1254,7 +1254,7 @@ export const Controls: FC<Props> = ({
                 <Text
                   style={[styles.endsAtText, { fontSize: typography.callout }]}
                 >
-                  {t("player.ends_at", { time: getFinishTime() })}
+                  {t("player.ends_at")} {getFinishTime()}
                 </Text>
               </View>
             )}
@@ -1448,7 +1448,7 @@ export const Controls: FC<Props> = ({
                 <Text
                   style={[styles.endsAtText, { fontSize: typography.callout }]}
                 >
-                  {t("player.ends_at", { time: getFinishTime() })}
+                  {t("player.ends_at")} {getFinishTime()}
                 </Text>
               </View>
             )}

scripts/detect-duplicate-issue.mjs

@@ -1,202 +0,0 @@
-#!/usr/bin/env bun
-/**
- * Flags likely-duplicate issues when a new issue is opened, using lexical similarity
- * (Jaccard over word sets of the title and body) — no API key, no embeddings.
- *
- * On a match it posts ONE comment listing the closest open issues and adds the
- * "possible duplicate" label. If nothing is similar enough, it does nothing.
- *
- * Env:
- *   GITHUB_REPOSITORY   owner/repo
- *   ISSUE_NUMBER        the new issue number
- *   ISSUE_TITLE         the new issue title
- *   ISSUE_BODY          the new issue body
- *   GH_TOKEN/GITHUB_TOKEN  for gh (provided in CI)
- *   DUP_THRESHOLD       similarity threshold 0..1 (default 0.3)
- *   DUP_MAX             max matches to report (default 5)
- *   DUP_FIXTURE         optional path to a JSON array of {number,title,body} (local testing)
- *   DRY_RUN             if set, print results instead of commenting/labelling
- */
-
-import { execFileSync } from "node:child_process";
-import { readFileSync } from "node:fs";
-
-const REPO = process.env.GITHUB_REPOSITORY || "streamyfin/streamyfin";
-const NUMBER = Number(process.env.ISSUE_NUMBER);
-const TITLE = process.env.ISSUE_TITLE || "";
-const BODY = process.env.ISSUE_BODY || "";
-const THRESHOLD = Number(process.env.DUP_THRESHOLD) || 0.3;
-const MAX = Number(process.env.DUP_MAX) || 5;
-const DRY = !!process.env.DRY_RUN;
-const LABEL = "possible duplicate";
-
-// Generic stop words only — keep domain/feature/platform words (android, downloads,
-// subtitles…) since those are exactly what makes two reports the same or different.
-const STOP = new Set(
-  (
-    "a an the and or but if then of to in on at by for with from as is are was were be been being do does did " +
-    "it its this that these those i you we they me my your our their he she him her " +
-    "when while where what which who how why so just then than too very can could would should will " +
-    "not no nor only own same s t don dont im ive please thanks hi hello also still get got use used using " +
-    "app application streamyfin issue bug"
-  ).split(/\s+/),
-);
-
-const stem = (w) => w.replace(/(ing|ed|es|s)$/, "");
-
-const tokens = (s) =>
-  (s || "")
-    .toLowerCase()
-    .replace(/```[\s\S]*?```/g, " ") // drop code blocks
-    .replace(/<!--[\s\S]*?-->/g, " ") // drop html comments
-    .replace(/https?:\/\/\S+/g, " ") // drop urls
-    .replace(/[^a-z0-9\s]/g, " ")
-    .split(/\s+/)
-    .filter((w) => w.length > 2 && !STOP.has(w))
-    .map(stem)
-    .filter((w) => w.length > 2);
-
-const jaccard = (a, b) => {
-  const A = new Set(a);
-  const B = new Set(b);
-  if (!A.size || !B.size) return 0;
-  let inter = 0;
-  for (const x of A) if (B.has(x)) inter++;
-  return inter / (A.size + B.size - inter);
-};
-
-const newTitle = tokens(TITLE);
-const newBody = tokens(BODY);
-const score = (o) =>
-  0.6 * jaccard(newTitle, tokens(o.title)) +
-  0.4 * jaccard(newBody, tokens(o.body));
-
-// fetch open issues (excluding PRs and the new issue itself)
-let issues;
-if (process.env.DUP_FIXTURE) {
-  issues = JSON.parse(readFileSync(process.env.DUP_FIXTURE, "utf8"));
-} else {
-  const raw = execFileSync(
-    "gh",
-    [
-      "api",
-      `repos/${REPO}/issues`,
-      "--paginate",
-      "-X",
-      "GET",
-      "-f",
-      "state=open",
-      "-f",
-      "per_page=100",
-      "--jq",
-      ".[] | select(.pull_request | not) | {number, title, body}",
-    ],
-    { encoding: "utf8", maxBuffer: 1e8 },
-  );
-  issues = raw
-    .split("\n")
-    .filter(Boolean)
-    .map((l) => JSON.parse(l));
-}
-
-const matches = issues
-  .filter((o) => o.number !== NUMBER)
-  .map((o) => ({ ...o, s: score(o) }))
-  .filter((o) => o.s >= THRESHOLD)
-  .sort((a, b) => b.s - a.s)
-  .slice(0, MAX);
-
-if (!matches.length) {
-  console.log("No likely duplicates found.");
-  process.exit(0);
-}
-
-// Neutralise other issues' titles before echoing them back: break @mentions and
-// strip markdown/HTML control chars so a maliciously-named issue can't ping people
-// or inject formatting into our comment. GitHub linkifies "#123" on its own.
-const safeTitle = (t) =>
-  (t || "")
-    .replace(/@/g, "@​")
-    .replace(/[`<>|*_~[\]]/g, " ")
-    .replace(/\s+/g, " ")
-    .trim()
-    .slice(0, 140);
-const list = matches
-  .map(
-    (m) =>
-      `- #${m.number} — ${safeTitle(m.title)} (≈ ${Math.round(m.s * 100)}% similar)`,
-  )
-  .join("\n");
-const comment = [
-  "<!-- duplicate-detector -->",
-  "🔍 **This looks like it might be a duplicate.** Possibly related open issues:",
-  "",
-  list,
-  "",
-  "If yours is different, ignore this — a maintainer will confirm. Otherwise, please 👍 the existing issue and add any extra details there.",
-].join("\n");
-
-console.log(`Found ${matches.length} possible duplicate(s):\n${list}`);
-
-if (DRY) {
-  console.log("\nDRY_RUN: not commenting/labelling.");
-  process.exit(0);
-}
-
-execFileSync(
-  "gh",
-  [
-    "api",
-    "-X",
-    "POST",
-    `repos/${REPO}/issues/${NUMBER}/comments`,
-    "-f",
-    `body=${comment}`,
-  ],
-  { stdio: "ignore" },
-);
-try {
-  execFileSync(
-    "gh",
-    [
-      "api",
-      "-X",
-      "POST",
-      `repos/${REPO}/issues/${NUMBER}/labels`,
-      "-f",
-      `labels[]=${LABEL}`,
-    ],
-    { stdio: "ignore" },
-  );
-} catch {
-  // label may not exist yet — create then add
-  execFileSync(
-    "gh",
-    [
-      "api",
-      "-X",
-      "POST",
-      `repos/${REPO}/labels`,
-      "-f",
-      `name=${LABEL}`,
-      "-f",
-      "color=fbca04",
-      "-f",
-      "description=Automatically flagged as a possible duplicate",
-    ],
-    { stdio: "ignore" },
-  );
-  execFileSync(
-    "gh",
-    [
-      "api",
-      "-X",
-      "POST",
-      `repos/${REPO}/issues/${NUMBER}/labels`,
-      "-f",
-      `labels[]=${LABEL}`,
-    ],
-    { stdio: "ignore" },
-  );
-}
-console.log("Commented and labelled.");